r106617 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106616‎ | r106617 | r106618 >
Date:00:51, 19 December 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Fix function name typo "date_defaulttimezone_get()" to "date_default_timezone_get()" from r105459
Modified paths:
  • /trunk/extensions/ParserFunctions/ParserFunctions_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ParserFunctions/ParserFunctions_body.php
——@@ -400,7 +400,7 @@
401401 if ( isset( $wgLocaltimezone ) ) {
402402 $tz = new DateTimeZone( $wgLocaltimezone );
403403 } else {
404 - $tz = new DateTimeZone( date_defaulttimezone_get() );
 404+ $tz = new DateTimeZone( date_default_timezone_get() );
405405 }
406406 $dateObject->setTimezone( $tz );
407407 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105459(bug 32351) Make #time[l] support explicitly specified timezones. Patch by V...bawolff20:52, 7 December 2011

Comments

#Comment by Bawolff (talk | contribs)   04:51, 19 December 2011

that's embarrassing.

It looks like that particular code path is never executed because $wgLocalTimezone gets set in Setup.php, which is probably why i missed it during testing r105459.

Status & tagging log