r106580 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106579‎ | r106580 | r106581 >
Date:18:44, 18 December 2011
Author:robin
Status:ok (Comments)
Tags:
Comment:
Make the messages labels for the input
Modified paths:
  • /trunk/extensions/Nuke/Nuke_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Nuke/Nuke_body.php
@@ -75,14 +75,14 @@
7676 )
7777 )
7878 . '<table><tr>'
79 - . '<td>' . htmlspecialchars( wfMsg( 'nuke-userorip' ) ) . '</td>'
80 - . '<td>' . Xml::input( 'target', 40, $userName ) . '</td>'
 79+ . '<td>' . Xml::label( wfMsg( 'nuke-userorip' ), 'nuke-target' ) . '</td>'
 80+ . '<td>' . Xml::input( 'target', 40, $userName, array( 'id' => 'nuke-target' ) ) . '</td>'
8181 . '</tr><tr>'
82 - . '<td>' . htmlspecialchars( wfMsg( 'nuke-pattern' ) ) . '</td>'
83 - . '<td>' . Xml::input( 'pattern', 40 ) . '</td>'
 82+ . '<td>' . Xml::label( wfMsg( 'nuke-pattern' ), 'nuke-pattern' ) . '</td>'
 83+ . '<td>' . Xml::input( 'pattern', 40, '', array( 'id' => 'nuke-pattern' ) ) . '</td>'
8484 . '</tr><tr>'
85 - . '<td>' . htmlspecialchars( wfMsg( 'nuke-maxpages' ) ) . '</td>'
86 - . '<td>' . Xml::input( 'limit', 7, '500' ) . '</td>'
 85+ . '<td>' . Xml::label( wfMsg( 'nuke-maxpages' ), 'nuke-limit' ) . '</td>'
 86+ . '<td>' . Xml::input( 'limit', 7, '500', array( 'id' => 'nuke-limit' ) ) . '</td>'
8787 . '</tr><tr>'
8888 . '<td></td>'
8989 . '<td>' . Xml::submitButton( wfMsg( 'nuke-submit-user' ) ) . '</td>'

Comments

#Comment by Nikerabbit (talk | contribs)   20:08, 18 December 2011

There is also Xml::inputLabelSep() that could reduce code here.

Status & tagging log