r106560 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106559‎ | r106560 | r106561 >
Date:13:50, 18 December 2011
Author:robin
Status:ok (Comments)
Tags:
Comment:
Clarify documentation
Modified paths:
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
——@@ -638,7 +638,8 @@
639639 }
640640
641641 /**
642 - * Get language names, indexed by code.
 642+ * Get native language names, indexed by code.
 643+ * Only those defined in MediaWiki, no other data like CLDR.
643644 * If $customisedOnly is true, only returns codes with a messages file
644645 *
645646 * @param $customisedOnly bool
——@@ -699,6 +700,8 @@
700701 }
701702
702703 /**
 704+ * Get the native language name of $code.
 705+ * Only if defined in MediaWiki, no other data like CLDR.
703706 * @param $code string
704707 * @return string
705708 */

Comments

#Comment by Nikerabbit (talk | contribs)   19:55, 18 December 2011 
+	 * Only if defined in MediaWiki, no other data like CLDR.

What happens only if that?

#Comment by SPQRobin (talk | contribs)   17:23, 22 December 2011

Uses of the function may depend on the fact that it returns only MediaWiki-defined languages. This is just to clarify what the function does. *If* we change the function to include other data, then that should be reflected in the documentation.

Status & tagging log