r106536 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106535‎ | r106536 | r106537 >
Date:23:58, 17 December 2011
Author:mah
Status:resolved (Comments)
Tags:
Comment:
Bug 33113 - Have buttons that are grayed out disabled completely
Author: joan.creus.c@gmail.com
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/styles/es.ToolbarView.css (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/styles/es.ToolbarView.css
——@@ -94,6 +94,9 @@
9595 filter:alpha(opacity=25);
9696 opacity: 0.25;
9797 }
 98+.es-toolbarButtonTool-disabled:hover {
 99+ border-color: transparent !important;
 100+}
98101 .es-toolbarButtonTool-clear:before {
99102 background-image: url(../images/clear.png);
100103 }

Sign-offs

UserFlagDate
GWickeinspected07:30, 21 December 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r108056re r106536 remove !transparentmah17:44, 4 January 2012

Comments

#Comment by Krinkle (talk | contribs)   13:20, 29 December 2011

Why the !important rule ? The need for that rule is very rare I don't think this is one of those cases. CSS cascades the rules down later rules overwrite earlier ones.

Since this rule has the same "score" (or "weight") as the :hover rule for normal buttons, this should work just fine. 

.es-toolbarButtonTool:hover,
.es-toolbarDropdownTool:hover {
	border-color: #eeeeee;
} 

.es-toolbarButtonTool-disabled:hover {
	border-color: transparent;
}
#Comment by Krinkle (talk | contribs)   13:21, 29 December 2011

(also spaces instead of tabs)

#Comment by Krinkle (talk | contribs)   13:22, 29 December 2011

As soon as !important is used, it messes with all cascading rules that come after. Should be avoided at all costs.

Status & tagging log