r106483 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106482‎ | r106483 | r106484 >
Date:22:33, 16 December 2011
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Fix parser error in r106480.

PHP Parse error: syntax error, unexpected T_ARRAY, expecting ')' in includes/installer/Ibm_db2Updater.php on line 55
Modified paths:
  • /trunk/phase3/includes/installer/Ibm_db2Updater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Ibm_db2Updater.php
@@ -51,7 +51,7 @@
5252 array( 'addTable', 'module_deps', 'patch-module_deps.sql' ),
5353 array( 'addIndex', 'module_deps', 'uq96_module_deps', 'patch-uq_96_module_deps.sql' ),
5454 array( 'addField', 'interwiki', 'iw_api', 'patch-iw_api-field.sql' ),
55 - array( 'addField', 'interwiki', 'iw_wikiid', 'patch-iw_wikiid-field.sql' )
 55+ array( 'addField', 'interwiki', 'iw_wikiid', 'patch-iw_wikiid-field.sql' ),
5656 array( 'addField', 'categorylinks', 'cl_sortkey_prefix', 'patch-cl_sortkey_prefix-field.sql' ),
5757 array( 'addField', 'categorylinks', 'cl_collation', 'patch-cl_collation-field.sql' ),
5858 array( 'addField', 'categorylinks', 'cl_type', 'patch-cl_type-field.sql' ),
@@ -72,4 +72,4 @@
7373 array( 'addField', 'archive', 'ar_sha1', 'patch-ar_sha1.sql' )
7474 );
7575 }
76 -}
\ No newline at end of file
 76+}

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106480Fixes to DB2 support:...leonsp21:17, 16 December 2011

Comments

#Comment by Leonsp (talk | contribs)   16:05, 17 December 2011

Mea culpa, thank you!:-)

#Comment by Platonides (talk | contribs)   22:34, 17 December 2011

No problem. :) It was easy to spot the intended contruction, and it was not in a very used file. Now, supposedly we had a lint commit check...

Status & tagging log