r106395 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106394‎ | r106395 | r106396 >
Date:23:46, 15 December 2011
Author:kaldari
Status:ok
Tags:
Comment:
follow-up to r101620 - 2nd variable is proceeded by a semicolon, not a comma, so needs another var declaration for it to be global (although that isnt strictly necessary in this case)
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -45,14 +45,14 @@
4646 $typeList.append( $( '<li tabindex="0"></li>' ).append( $button ) );
4747 }
4848
49 - var commonsLink = $( '<a>' )
 49+ var commonsLink = $( '<a>' )
5050 .attr( 'href', mw.msg( 'wikilove-commons-url' ) )
5151 .attr( 'target', '_blank' )
5252 .text( mw.msg( 'wikilove-commons-link' ) )
5353 .wrap( '<div>' ) // or .html() will only return the link text
5454 .parent()
5555 .html();
56 - termsLink = $( '<a> ')
 56+ var termsLink = $( '<a> ')
5757 .attr( 'href', mw.msg( 'wikilove-terms-url' ) )
5858 .attr( 'target', '_blank' )
5959 .text( mw.msg( 'wikilove-terms-link' ) )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101620Followup r101618: actually make things work. You can't feed HTML to mw.msg() ...catrope12:34, 2 November 2011

Status & tagging log