r106300 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106299‎ | r106300 | r106301 >
Date:01:55, 15 December 2011
Author:preilly
Status:deferred
Tags:mobile 
Comment:
remove placeholder
Modified paths:
  • /trunk/extensions/MobileFrontend/ApplicationTemplate.php (modified) (history)
  • /trunk/extensions/MobileFrontend/javascripts/beta_opensearch.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/ApplicationTemplate.php
@@ -24,7 +24,7 @@
2525 $endScriptTag = '"></script>';
2626 $javaScriptPath = $this->data['wgExtensionAssetsPath'] . '/MobileFrontend/javascripts/';
2727
28 - $openSearchScript = $startScriptTag . $javaScriptPath . $betaPrefix . 'opensearch.js?version=12012011126437' . $endScriptTag;
 28+ $openSearchScript = $startScriptTag . $javaScriptPath . $betaPrefix . 'opensearch.js?version=12142011126437' . $endScriptTag;
2929 $jQueryScript = ( $this->data['device']['supports_jquery'] ) ? $startScriptTag . $javaScriptPath . 'jquery-1.7.1.min.js' . $endScriptTag : '';
3030 $filePageScript = ( $this->data['isFilePage'] ) ? $startScriptTag . $javaScriptPath . 'filepage.js' . $endScriptTag : '';
3131
Index: trunk/extensions/MobileFrontend/javascripts/beta_opensearch.js
@@ -110,6 +110,12 @@
111111 if ( footer ) {
112112 footer.style.display = 'block';
113113 }
 114+
 115+ var pE = document.getElementById( 'placeholder' );
 116+ if ( pE ) {
 117+ pE.style.display = 'none';
 118+ }
 119+
114120 if ( ol ) {
115121 if ( sq ) {
116122 logo.style.visibility = 'visible';

Follow-up revisions

RevisionCommit summaryAuthorDate
r1063011.18wmf1: MFT r106300preilly01:55, 15 December 2011

Status & tagging log