r106295 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106294‎ | r106295 | r106296 >
Date:00:38, 15 December 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:

Remove stray trailing commas on last items in array literals -- this breaks IE 6/7/8

Followup r105560
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
——@@ -492,7 +492,7 @@
493493 [ '13,000'],
494494 [ '9' ],
495495 [ '14' ],
496 - [ '8.0' ],
 496+ [ '8.0' ]
497497 ];
498498 var numbersAsc = [
499499 [ '7' ],
——@@ -500,7 +500,7 @@
501501 [ '9' ],
502502 [ '12' ],
503503 [ '14' ],
504 - [ '13,000'],
 504+ [ '13,000']
505505 ];
506506
507507 tableTest( 'bug 8115: sort numbers with commas (ascending)',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105560basic tests for bug 8115hashar16:27, 8 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   08:58, 15 December 2011

What I would live is some JS validator that could be instructed to go over all the JS files we have.

#Comment by Krinkle (talk | contribs)   10:52, 30 December 2011

Good idea, I might try something with the JSLint/JSHint API.

Status & tagging log