r106276 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106275‎ | r106276 | r106277 >
Date:23:02, 14 December 2011
Author:kroocsiogsi
Status:resolved (Comments)
Tags:
Comment:
Rename third-party license for clarity
Modified paths:
  • /trunk/extensions/SoundManager2Button/SoundManager2+BSD+license.txt (added) (history)
  • /trunk/extensions/SoundManager2Button/license.txt (deleted) (history)

Diff [purge]

Index: trunk/extensions/SoundManager2Button/license.txt
@@ -1,29 +0,0 @@
2 -Software License Agreement (BSD License)
3 -
4 -Copyright (c) 2007, Scott Schiller (schillmania.com)
5 -All rights reserved.
6 -
7 -Redistribution and use in source and binary forms, with or without modification,
8 -are permitted provided that the following conditions are met:
9 -
10 -* Redistributions of source code must retain the above copyright notice, this
11 - list of conditions and the following disclaimer.
12 -
13 -* Redistributions in binary form must reproduce the above copyright notice, this
14 - list of conditions and the following disclaimer in the documentation and/or
15 - other materials provided with the distribution.
16 -
17 -* Neither the name of schillmania.com nor the names of its contributors may be
18 - used to endorse or promote products derived from this software without
19 - specific prior written permission from schillmania.com.
20 -
21 -THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
22 -ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
23 -WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
24 -DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
25 -ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
26 -(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
27 -LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
28 -ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
29 -(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
30 -SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
\ No newline at end of file
Index: trunk/extensions/SoundManager2Button/SoundManager2 BSD license.txt
@@ -0,0 +1,29 @@
 2+Software License Agreement (BSD License)
 3+
 4+Copyright (c) 2007, Scott Schiller (schillmania.com)
 5+All rights reserved.
 6+
 7+Redistribution and use in source and binary forms, with or without modification,
 8+are permitted provided that the following conditions are met:
 9+
 10+* Redistributions of source code must retain the above copyright notice, this
 11+ list of conditions and the following disclaimer.
 12+
 13+* Redistributions in binary form must reproduce the above copyright notice, this
 14+ list of conditions and the following disclaimer in the documentation and/or
 15+ other materials provided with the distribution.
 16+
 17+* Neither the name of schillmania.com nor the names of its contributors may be
 18+ used to endorse or promote products derived from this software without
 19+ specific prior written permission from schillmania.com.
 20+
 21+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
 22+ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
 23+WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 24+DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
 25+ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
 26+(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
 27+LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
 28+ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 29+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
 30+SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
\ No newline at end of file
Property changes on: trunk/extensions/SoundManager2Button/SoundManager2 BSD license.txt
___________________________________________________________________
Added: svn:eol-style
131 + native
Added: svn:keywords
232 + Author Date Id Rev URL

Follow-up revisions

RevisionCommit summaryAuthorDate
r106463Use underscores instead of spaces in file name.kroocsiogsi19:04, 16 December 2011

Comments

#Comment by 😂 (talk | contribs)   16:39, 16 December 2011

Rather than using spaces in filenames, could you please use underscores or dashes?

#Comment by Kroocsiogsi (talk | contribs)   19:06, 16 December 2011

Done. This is my first time correcting a patch; please let me know if I did it correctly. Thanks.

#Comment by Kroocsiogsi (talk | contribs)   06:57, 20 December 2011

Oh, maybe I need to mark it "resolved"?

#Comment by Bawolff (talk | contribs)   07:02, 20 December 2011

Generally once you fix an issue you mark it "new" to signify its good to be re-reviewed (other people mark it resolved once its been re-reviewed).


It doesn't really matter since the file didn't have any history, but for future reference, in svn, to rename a file you should do something like:

svn mv oldName newName

That way the history of the file is preserved in svn.

Status & tagging log