r106269 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106268‎ | r106269 | r106270 >
Date:22:38, 14 December 2011
Author:preilly
Status:deferred (Comments)
Tags:mobile 
Comment:
add noprint to mobile view link
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -307,7 +307,7 @@
308308 $footerlinks = $tpl->data['footerlinks'];
309309 $mobileViewUrl = $wgRequest->escapeAppendQuery( 'useformat=mobile' );
310310
311 - $tpl->set( 'mobileview', "<a href='{$mobileViewUrl}'>" . wfMsg( 'mobile-frontend-view' ) . "</a>" );
 311+ $tpl->set( 'mobileview', "<a href='{$mobileViewUrl}' class='noprint'>" . wfMsg( 'mobile-frontend-view' ) . "</a>" );
312312 $footerlinks['places'][] = 'mobileview';
313313 $tpl->set( 'footerlinks', $footerlinks );
314314 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r1062831.18wmf1: MFT r106269 - r106231preilly23:55, 14 December 2011
r106350add noprint to mobileviewpreilly18:29, 15 December 2011

Comments

#Comment by TheDJ (talk | contribs)   08:40, 15 December 2011

This is inside the li element.... I wonder if the bullet of the li will still show up..

http://de.wikipedia.org/wiki/Wikipedia:Hauptseite?printable=yes&debug=true&useskin=monobook

answer yes :(

#Comment by Preilly (talk | contribs)   18:30, 15 December 2011

This should be fixed in r106350.

Status & tagging log