r106172 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106171‎ | r106172 | r106173 >
Date:11:38, 14 December 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Blacklist IE6 and IE8&XP combos because of known issues with font rendering
Modified paths:
  • /trunk/extensions/WebFonts/resources/ext.webfonts.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/resources/ext.webfonts.js
@@ -167,6 +167,18 @@
168168 * It also apply the font from cookie, if any.
169169 */
170170 setup: function() {
 171+ // Blacklist some browsers that are known to have issues with font rendering
 172+ if ( navigator.appName === 'Microsoft Internet Explorer' ) {
 173+ var ua = navigator.userAgent;
 174+ if ( /MSIE 6/i.test( ua ) ) {
 175+ // IE6 has not font fallbacks
 176+ return;
 177+ } else if ( /MSIE 8/i.test( ua ) && /Windows NT 5.1/i.test( ua ) ) {
 178+ // IE8 on XP has occasional gibberish bug
 179+ return;
 180+ }
 181+ }
 182+
171183 var config = [];
172184 var languages = mw.webfonts.config.languages;
173185 var requested = [mw.config.get( 'wgUserVariant' ), mw.config.get( 'wgContentLanguage' ), mw.config.get( 'wgUserLanguage' )];

Sign-offs

UserFlagDate
Siebrandtested13:45, 14 December 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r106204MFT r106172 r106175 r106179 r106191nikerabbit15:24, 14 December 2011

Status & tagging log