r106153 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106152‎ | r106153 | r106154 >
Date:01:23, 14 December 2011
Author:preilly
Status:ok (Comments)
Tags:
Comment:
fix logout link
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -150,6 +150,7 @@
151151 public static $wsLoginToken = '';
152152 public static $wsLoginFormAction = '';
153153 public static $isFilePage;
 154+ public static $logoutHtml;
154155
155156 public static $messageKeys = array(
156157 'mobile-frontend-show-button',
@@ -1316,7 +1317,7 @@
13171318
13181319 if ( $ptLogout ) {
13191320 $ptLogoutLink = $ptLogout->firstChild;
1320 - $logoutHtml = $this->doc->saveXML( $ptLogoutLink, LIBXML_NOEMPTYTAG );
 1321+ self::$logoutHtml = $this->doc->saveXML( $ptLogoutLink, LIBXML_NOEMPTYTAG );
13211322 }
13221323
13231324 if ( self::$title->isSpecial( 'Userlogin' ) && self::$isBetaGroupMember ) {
@@ -1517,7 +1518,7 @@
15181519 public function getFooterTemplate() {
15191520 wfProfileIn( __METHOD__ );
15201521 $footerTemplate = new FooterTemplate();
1521 - $logoutHtml = ( !empty( $logoutHtml ) ) ? $logoutHtml : '';
 1522+ $logoutHtml = ( !empty( self::$logoutHtml ) ) ? self::$logoutHtml : '';
15221523 $options = array(
15231524 'messages' => self::$messages,
15241525 'leaveFeedbackURL' => self::$leaveFeedbackURL,

Follow-up revisions

RevisionCommit summaryAuthorDate
r1061541.18wmf1: MFT r106153preilly01:24, 14 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:57, 14 December 2011

Bit by empty? It really suppresses these kinds of errors.

Status & tagging log