r106124 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106123‎ | r106124 | r106125 >
Date:23:15, 13 December 2011
Author:tparscal
Status:ok
Tags:
Comment:
Fixes issue with r106123 where creating new links wasn't working anymore with the button
Modified paths:
  • /trunk/extensions/VisualEditor/modules/es/tools/es.AnnotationButtonTool.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VisualEditor/modules/es/tools/es.AnnotationButtonTool.js
@@ -23,7 +23,9 @@
2424 es.AnnotationButtonTool.prototype.onClick = function() {
2525 var surfaceView = this.toolbar.getSurfaceView();
2626 if ( this.inspector ) {
27 - if ( !surfaceView.getModel().getSelection().getLength() ) {
 27+ if ( surfaceView.getModel().getSelection().getLength() ) {
 28+ this.toolbar.getSurfaceView().getContextView().openInspector( this.inspector );
 29+ } else {
2830 if ( this.active ) {
2931 var surfaceModel = surfaceView.getModel(),
3032 documentModel = surfaceModel.getDocument(),

Follow-up revisions

RevisionCommit summaryAuthorDate
r106249MFT r106123, r106124, r106127, r106157, r106224, r106230 misc fixes to common...neilk21:58, 14 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r106123- Added auto-link selection when opening the link editor without selecting an...tparscal23:12, 13 December 2011

Status & tagging log