r106058 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106057‎ | r106058 | r106059 >
Date:18:40, 13 December 2011
Author:yonishostak
Status:ok
Tags:
Comment:
AFTv5: fix bug 32933 - tooltip, close, dialogs, panels
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -1912,6 +1912,13 @@
19131913 );
19141914
19151915 return $block;
 1916+ },
 1917+
 1918+ /**
 1919+ * Perform adjustments after build
 1920+ */
 1921+ afterBuild: function() {
 1922+ $( '.articleFeedbackv5-tooltip-trigger' ).remove();
19161923 }
19171924
19181925 // }}}
@@ -2517,6 +2524,12 @@
25182525 if ( 'afterBuild' in cta ) {
25192526 cta.afterBuild();
25202527 }
 2528+
 2529+ // The close element needs to be created anyway, to serve as an anchor. However, it needs
 2530+ // to be hidden when the CTA is not displayed in a dialog
 2531+ if( !$.articleFeedbackv5.inDialog ) {
 2532+ $close.hide();
 2533+ }
25212534
25222535 // Reset the panel dimensions
25232536 $.articleFeedbackv5.setDialogDimensions();

Status & tagging log