r106044 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106043‎ | r106044 | r106045 >
Date:16:51, 13 December 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Add a newline, the below isn't too readable

Fixing protocol-relative entries in the externallinks table...
10020030040050060070080090010001100120013001400150016001700180019002000Done, 2007 rows updated.
Modified paths:
  • /trunk/phase3/maintenance/fixExtLinksProtocolRelative.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/fixExtLinksProtocolRelative.php
@@ -37,7 +37,7 @@
3838 protected function updateSkippedMessage() {
3939 return 'protocol-relative URLs in externallinks table already fixed.';
4040 }
41 -
 41+
4242 protected function doDBUpdates() {
4343 $db = wfGetDB( DB_MASTER );
4444 if ( !$db->tableExists( 'externallinks' ) ) {
@@ -53,7 +53,7 @@
5454 foreach ( $res as $row ) {
5555 $count++;
5656 if ( $count % 100 == 0 ) {
57 - $this->output( $count );
 57+ $this->output( $count . "\n" );
5858 wfWaitForSlaves();
5959 }
6060 $db->insert( 'externallinks',

Follow-up revisions

RevisionCommit summaryAuthorDate
r106045Merge r106044reedy16:52, 13 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   21:38, 13 December 2011

Fortunately we don't have that many external links ;D

Status & tagging log