r106037 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106036‎ | r106037 | r106038 >
Date:15:49, 13 December 2011
Author:jeroendedauw
Status:resolved (Comments)
Tags:
Comment:
Follow up to r105979;
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
——@@ -3460,7 +3460,7 @@
34613461 if ( !isset( $functionsWarned[$function] ) ) {
34623462 $functionsWarned[$function] = true;
34633463
3464 - if ( $version ) {
 3464+ if ( $version && $component === false ) {
34653465 global $wgDeprecationReleaseLimit;
34663466
34673467 if ( $wgDeprecationReleaseLimit ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r106042Follow up to r106037; fix location of checkjeroendedauw16:42, 13 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105979add support for passing a component arg to this function, so it can be used b...jeroendedauw04:42, 13 December 2011

Comments

#Comment by 😂 (talk | contribs)   15:50, 13 December 2011

Could you please use a more descriptive commit message? Without opening the old diff and reading the CR, there's no context for this change.

#Comment by Jeroen De Dauw (talk | contribs)   15:57, 13 December 2011

What would such a message be? "Added missing check"? You can sort of deduce that from the diff here.

#Comment by 😂 (talk | contribs)   16:20, 13 December 2011

Something like "can't use $component and $wgDeprecationReleaseLimit."

Anyway, shouldn't the $component check be moved down to $wgDeprecationReleaseLimit? Where you've got it now you make it impossible to use a $component.

#Comment by Jeroen De Dauw (talk | contribs)   16:43, 13 December 2011

Right. Got bitten by the nested ifs :) Fixed in follow up.

Status & tagging log