r106005 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r106004‎ | r106005 | r106006 >
Date:10:36, 13 December 2011
Author:raymond
Status:ok
Tags:
Comment:
Partly revert r105985 for now: Flooding of translatewiki.net log/channel:
PHP Notice: Use of Linker::makeLinkObj was deprecated in MediaWiki 1.16. [Called from call_user_func_array in (internal function)] in /www/w/includes/GlobalFunctions.php on line 3520
PHP Notice: Use of Linker::makeKnownLinkObj was deprecated in MediaWiki 1.16. [Called from call_user_func_array in (internal function)] in /www/w/includes/GlobalFunctions.php on line 3520
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
——@@ -1903,7 +1903,7 @@
19041904 * @param $prefix String: optional prefix. As trail, only before instead of after.
19051905 */
19061906 static function makeLinkObj( $nt, $text = '', $query = '', $trail = '', $prefix = '' ) {
1907 - wfDeprecated( __METHOD__, '1.16' );
 1907+ # wfDeprecated( __METHOD__, '1.16' ); // See r105985 and it's revert. Somewhere still used.
19081908
19091909 wfProfileIn( __METHOD__ );
19101910 $query = wfCgiToArray( $query );
——@@ -1937,7 +1937,7 @@
19381938 static function makeKnownLinkObj(
19391939 $title, $text = '', $query = '', $trail = '', $prefix = '' , $aprops = '', $style = ''
19401940 ) {
1941 - wfDeprecated( __METHOD__, '1.16' );
 1941+ # wfDeprecated( __METHOD__, '1.16' ); // See r105985 and it's revert. Somewhere still used.
19421942
19431943 wfProfileIn( __METHOD__ );
19441944

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105985add missing deprecation notices and added deprecation version to existing onesjeroendedauw05:19, 13 December 2011

Status & tagging log