r106004 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r106003‎ | r106004 | r106005 >
Date:10:28, 13 December 2011
Author:neilk
Status:ok
Tags:
Comment:
change args for feedback and api -- all optional, in array.
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)
  • /trunk/extensions/VisualEditor/modules/sandbox/special.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -61,11 +61,10 @@
6262 $j( '#contentSub' ).append( $j( '<span style="margin-right: 0.5em;"></span>' ).msg( 'mwe-upwiz-subhead-message' ) );
6363 // feedback request
6464 if ( mw.UploadWizard.config['feedbackPage'] !== undefined && mw.UploadWizard.config['feedbackPage'] !== '' ) {
65 - var feedback = new mw.Feedback(
66 - _this.api,
67 - new mw.Title( mw.UploadWizard.config['feedbackPage'] ),
68 - 'mwe-upwiz-feedback-title'
69 - );
 65+ var feedback = new mw.Feedback( {
 66+ 'title': new mw.Title( mw.UploadWizard.config['feedbackPage'] ),
 67+ 'dialogTitleMessageKey': 'mwe-upwiz-feedback-title'
 68+ } );
7069 var feedbackLink = $j( '<span class="contentSubLink"></span>' ).msg( 'mwe-upwiz-feedback-prompt',
7170 function() {
7271 feedback.launch();
Index: trunk/extensions/VisualEditor/modules/sandbox/special.js
@@ -3,19 +3,12 @@
44 $(document).ready( setupSpecial );
55
66 function setupSpecial() {
7 -
8 - var api = new mw.Api( {
9 - url: mw.config.get( 'wgServer' ) + mw.config.get( 'wgScriptPath' ) + '/api.php'
 7+
 8+ var feedback = new mw.Feedback( {
 9+ 'title': new mw.Title( 'Visual editor/Feedback' ),
 10+ 'dialogTitleMessageKey': 'visualeditor-feedback-dialog-title'
1011 } );
1112
12 - var title = new mw.Title( 'Visual editor/Feedback' );
13 -
14 - var feedback = new mw.Feedback(
15 - api,
16 - title,
17 - 'visualeditor-feedback-dialog-title'
18 - );
19 -
2013 $feedbackLink = $( '<a></a>' )
2114 .attr( { 'href': '#' } )
2215 .text( mw.msg( 'visualeditor-feedback-prompt' ) )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105972add feedback link to visual editorneilk02:46, 13 December 2011

Status & tagging log