r105959 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105958‎ | r105959 | r105960 >
Date:00:27, 13 December 2011
Author:seanheavey
Status:resolved (Comments)
Tags:
Comment:
ie compatability enhancements for option 2. bug 32938 bug 32936
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.css (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/moodbar_emoticon_hover_confused.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/moodbar_emoticon_hover_happy.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/moodbar_emoticon_hover_lightbulb.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/moodbar_emoticon_hover_sad.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/moodbar_emoticon_hover_confused.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/moodbar_emoticon_hover_confused.png
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/moodbar_emoticon_hover_sad.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/moodbar_emoticon_hover_sad.png
___________________________________________________________________
Added: svn:mime-type
22 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/moodbar_emoticon_hover_lightbulb.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/moodbar_emoticon_hover_lightbulb.png
___________________________________________________________________
Added: svn:mime-type
33 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/moodbar_emoticon_hover_happy.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/moodbar_emoticon_hover_happy.png
___________________________________________________________________
Added: svn:mime-type
44 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -676,6 +676,7 @@
677677 /*** Option 2 ***/
678678 .articleFeedbackv5-tags ul {
679679 margin: 0 0 10px;
 680+ list-style: none;
680681 }
681682 .articleFeedbackv5-tags ul:after {
682683 clear: both;
@@ -683,18 +684,16 @@
684685 .articleFeedbackv5-tags ul li {
685686 color: #666;
686687 list-style: none;
687 - float: left;
 688+ float: left !important;
 689+ display:block;
688690 margin: 0 0 0 20px;
689691 line-height: 28px;
690692 height: 28px;
691693 padding: 1px 9px;
692694 position: relative;
 695+ white-space: nowrap;
693696 }
694 -.articleFeedbackv5-tags ul li:hover {
695 - float: left;
696 -}
697697
698 -
699698 .articleFeedbackv5-tags ul li:first-child {
700699 margin: 0;
701700 }
@@ -741,42 +740,42 @@
742741
743742 .articleFeedbackv5-tags ul li .articleFeedbackv5-bucket2-suggestion-label {
744743 /* @embed */
745 - background: url(images/bg-tag-suggestion-on.png) no-repeat 0 center;
 744+ background: url(images/moodbar_emoticon_hover_lightbulb.png) no-repeat 0 center;
746745 }
747746
748747 .articleFeedbackv5-tags ul li .articleFeedbackv5-bucket2-question-label {
749748 /* @embed */
750 - background: url(images/bg-tag-question-on.png) no-repeat 0 center;
 749+ background: url(images/moodbar_emoticon_set_confused.png) no-repeat 0 center;
751750 }
752751
753752 .articleFeedbackv5-tags ul li .articleFeedbackv5-bucket2-problem-label {
754753 /* @embed */
755 - background: url(images/bg-tag-problem-on.png) no-repeat 0 center;
 754+ background: url(images/moodbar_emoticon_hover_sad.png) no-repeat 0 center;
756755 }
757756
758757 .articleFeedbackv5-tags ul li .articleFeedbackv5-bucket2-praise-label {
759758 /* @embed */
760 - background: url(images/bg-tag-praise-on.png) no-repeat 0 center;
 759+ background: url(images/moodbar_emoticon_hover_happy.png) no-repeat 0 center;
761760 }
762761
763762 /*.articleFeedbackv5-tags ul li:hover .articleFeedbackv5-bucket2-suggestion-label,
764763 .articleFeedbackv5-tags ul li.active .articleFeedbackv5-bucket2-suggestion-label {
765 - background: url(images/bg-tag-suggestion-on.png) no-repeat 0 center;
 764+ background: url(images/moodbar_emoticon_hover_lightbulb.png) no-repeat 0 center;
766765 }
767766
768767 .articleFeedbackv5-tags ul li:hover .articleFeedbackv5-bucket2-question-label,
769768 .articleFeedbackv5-tags ul li.active .articleFeedbackv5-bucket2-question-label {
770 - background: url(images/bg-tag-question-on.png) no-repeat 0 center;
 769+ background: url(images/moodbar_emoticon_set_confused.png) no-repeat 0 center;
771770 }
772771
773772 .articleFeedbackv5-tags ul li:hover .articleFeedbackv5-bucket2-problem-label,
774773 .articleFeedbackv5-tags ul li.active .articleFeedbackv5-bucket2-problem-label {
775 - background: url(images/bg-tag-problem-on.png) no-repeat 0 center;
 774+ background: url(images/moodbar_emoticon_hover_sad.png) no-repeat 0 center;
776775 }
777776
778777 .articleFeedbackv5-tags ul li:hover .articleFeedbackv5-bucket2-praise-label,
779778 .articleFeedbackv5-tags ul li.active .articleFeedbackv5-bucket2-praise-label {
780 - background: url(images/bg-tag-praise-on.png) no-repeat 0 center;
 779+ background: url(images/moodbar_emoticon_hover_happy.png) no-repeat 0 center;
781780 }*/
782781
783782 /*** Option 3 ***/
Index: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.ie.css
@@ -0,0 +1,51 @@
 2+.articleFeedbackv5-ui .articleFeedbackv5-submit {
 3+ min-width: 190px;
 4+}
 5+.articleFeedbackv5-tags ul {
 6+ margin: 0;
 7+ padding: 0;
 8+ display: block;
 9+ list-style: none;
 10+}
 11+.articleFeedbackv5-tags ul li {
 12+ margin: 0 2% 5px 0;
 13+ border: 0;
 14+ list-style: none;
 15+}
 16+.articleFeedbackv5-tags ul li {
 17+ display: block !important;
 18+ float: left !important;
 19+ width: 20% !important;
 20+ white-space:nowrap;
 21+ text-align: center;
 22+ line-height: 18px !important;
 23+}
 24+.articleFeedbackv5-fixedtab {
 25+ position: static !important;
 26+ top: 0 !important;
 27+ left: 0 !important;
 28+}
 29+.articleFeedbackv5-fixedtablink {
 30+ position: absolute;
 31+ min-width: 105px;
 32+ left: 0;
 33+ display: inline-block;
 34+ height: 20px;
 35+ margin: 0;
 36+ padding: 5px 10px;
 37+ color: .333;
 38+ border: 1px solid #555599;
 39+ border-top: none;
 40+ background-color: #0C0;
 41+ text-align: center;
 42+ /*writing-mode: tb-rl;*/
 43+ /*-moz-transform:rotate(90deg);
 44+ -moz-transform-origin: top left;
 45+ -webkit-transform: rotate(90deg);
 46+ -webkit-transform-origin: top left;
 47+ -o-transform: rotate(90deg);
 48+ -o-transform-origin: top left;
 49+ transform: rotate(90deg);
 50+ transform-origin: top left;
 51+ filter: progid:DXImageTransform.Microsoft.Matrix(M11=-1.0,M12=0.0,M21=0.0,M22=1.0);*/
 52+}
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r105961adjusted styles for new icons and ie compatability. bug 32945 bug 32938seanheavey00:41, 13 December 2011
r106112Followup r105959: set MIME typecatrope22:02, 13 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   05:47, 13 December 2011

The mime types for the images look wrong.

Status & tagging log