r105935 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105934‎ | r105935 | r105936 >
Date:22:05, 12 December 2011
Author:robin
Status:resolved (Comments)
Tags:
Comment:
not sure if this span is really needed, but in any case it depends on user language, not content language
Modified paths:
  • /trunk/phase3/includes/SkinLegacy.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinLegacy.php
——@@ -345,7 +345,7 @@
346346 }
347347
348348 function otherLanguages() {
349 - global $wgOut, $wgContLang, $wgHideInterlanguageLinks;
 349+ global $wgOut, $wgLang, $wgHideInterlanguageLinks;
350350
351351 if ( $wgHideInterlanguageLinks ) {
352352 return '';
——@@ -360,8 +360,8 @@
361361 $s = wfMsg( 'otherlanguages' ) . wfMsg( 'colon-separator' );
362362 $first = true;
363363
364 - if ( $wgContLang->isRTL() ) {
365 - $s .= '<span dir="LTR">';
 364+ if ( $wgLang->isRTL() ) {
 365+ $s .= '<span dir="ltr">';
366366 }
367367
368368 foreach ( $a as $l ) {
——@@ -379,7 +379,7 @@
380380 $text == '' ? $l : $text );
381381 }
382382
383 - if ( $wgContLang->isRTL() ) {
 383+ if ( $wgLang->isRTL() ) {
384384 $s .= '</span>';
385385 }
386386

Follow-up revisions

RevisionCommit summaryAuthorDate
r105936fix r105935, wgContLang still used in the functionrobin22:08, 12 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   05:15, 13 December 2011

Which span is it?

#Comment by SPQRobin (talk | contribs)   10:47, 13 December 2011

How do you mean? It's a span around the interwiki language names, using a legacy skin.

Status & tagging log