r105897 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105896‎ | r105897 | r105898 >
Date:15:51, 12 December 2011
Author:brion
Status:ok
Tags:
Comment:
Followup r105853 -- another instance of $request->getVal('filter', 'all') to replace with $this->filter
Modified paths:
  • /trunk/phase3/includes/specials/SpecialAllmessages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialAllmessages.php
——@@ -121,7 +121,7 @@
122122 if( $this->filter === 'all' ){
123123 $this->custom = null; // So won't match in either case
124124 } else {
125 - $this->custom = ($request->getVal( 'filter' ) == 'unmodified');
 125+ $this->custom = ($this->filter == 'unmodified');
126126 }
127127
128128 $prefix = $this->getLanguage()->ucfirst( $request->getVal( 'prefix', '' ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r107926MFT r105341, r105853, r105897reedy19:26, 3 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105853* (bug 32958) SpecialAllMessages: input form doesn't show and remember filter...brion06:27, 12 December 2011

Status & tagging log