r105872 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105871‎ | r105872 | r105873 >
Date:13:11, 12 December 2011
Author:demon
Status:reverted (Comments)
Tags:
Comment:
(bug 32984) ar_sha1 might not be set
Modified paths:
  • /trunk/phase3/includes/Revision.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Revision.php
——@@ -124,7 +124,7 @@
125125 'text_id' => isset( $row->ar_text_id ) ? $row->ar_text_id : null,
126126 'deleted' => $row->ar_deleted,
127127 'len' => $row->ar_len,
128 - 'sha1' => $row->ar_sha1
 128+ 'sha1' => isset( $row->ar_sha1 ) ? $row->ar_sha1 : null,
129129 );
130130 if ( isset( $row->ar_text ) && !$row->ar_text_id ) {
131131 // Pre-1.5 ar_text row

Follow-up revisions

RevisionCommit summaryAuthorDate
r105874Self-revert r105872, there's a deeper issue heredemon13:45, 12 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   13:30, 12 December 2011

The relevant question is why it is not set. It is impossible to say whether this is the correct fix without knowing the cause.

#Comment by 😂 (talk | contribs)   13:36, 12 December 2011

If ar_sha1 wasn't populated for all revs yet?

#Comment by Siebrand (talk | contribs)   13:39, 12 December 2011

/www/w/maintenance$ b php populateRevisionSha1.php ...Update 'populate rev_sha1' already logged as completed.

Should that script maybe also populate the archived revs?

#Comment by 😂 (talk | contribs)   13:41, 12 December 2011

Good idea, if it doesn't already. Can't find anything in BZ about it.

#Comment by Siebrand (talk | contribs)   13:43, 12 December 2011

Looks like ar_sha1 is fully populated in translatewiki. So this issue may have another origin.

Status & tagging log