r105865 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105864‎ | r105865 | r105866 >
Date:10:48, 12 December 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
update message when dropping index ('index' not 'key')

Follow r99524
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -490,7 +490,7 @@
491491 */
492492 protected function dropIndex( $table, $index, $patch, $fullpath = false ) {
493493 if ( $this->db->indexExists( $table, $index, __METHOD__ ) ) {
494 - $this->output( "Dropping $index key from table $table... " );
 494+ $this->output( "Dropping $index index from table $table... " );
495495 $this->applyPatch( $patch, $fullpath );
496496 $this->output( "done.\n" );
497497 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99524added 'key' in 'Dropping .. key' in dropIndex which was missing therewikinaut18:33, 11 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   14:28, 12 December 2011

Don't we usually say thing X rather than X thing?

Status & tagging log