r105862 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105861‎ | r105862 | r105863 >
Date:10:25, 12 December 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
Better output message for ApiPurgeTests

Follow up r10833
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/api/ApiPurgeTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/api/ApiPurgeTest.php
@@ -22,9 +22,12 @@
2323 'action' => 'purge',
2424 'titles' => 'UTPage|' . $somePage . '|%5D' ) );
2525
26 - $this->assertArrayHasKey( 'purge', $data[0] );
27 - $this->assertEquals( 3, count( $data[0]['purge'] ) );
 26+ $this->assertArrayHasKey( 'purge', $data[0],
 27+ "Must receive a 'purge' result from API" );
2828
 29+ $this->assertEquals( 3, count( $data[0]['purge'] ),
 30+ "Purge request for three articles should give back three results received: " . var_export( $data[0]['purge'], true ) );
 31+
2932 $pages = array( 'UTPage' => 'purged', $somePage => 'missing', '%5D' => 'invalid' );
3033 foreach( $data[0]['purge'] as $v ) {
3134 $this->assertArrayHasKey( $pages[$v['title']], $v );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r10833* Security fix for <math>...vibber23:34, 29 August 2005

Comments

#Comment by Nikerabbit (talk | contribs)   15:47, 12 December 2011

should there be punctuation before word received?

Status & tagging log