r105845 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105844‎ | r105845 | r105846 >
Date:00:50, 12 December 2011
Author:aaron
Status:deferred (Comments)
Tags:
Comment:
FU r105819: missing sql file change
Modified paths:
  • /branches/FileBackend/phase3/maintenance/locking/file_locks.sql (modified) (history)

Diff [purge]

Index: branches/FileBackend/phase3/maintenance/locking/file_locks.sql
@@ -1,4 +1,10 @@
22 -- Create table to handle resource locking
3 -CREATE TABLE /*$wgDBprefix*/file_locks (
4 - fl_key binary(40) NOT NULL default '' PRIMARY KEY
 3+CREATE TABLE /*_*/file_locks_exclusive (
 4+ fle_key binary(40) NOT NULL default '' PRIMARY KEY
55 ) ENGINE=InnoDB, DEFAULT CHARSET=binary;
 6+
 7+-- Create table to handle resource locking
 8+CREATE TABLE /*_*/file_locks_shared (
 9+ fls_key binary(40) NOT NULL default ''
 10+) ENGINE=InnoDB, DEFAULT CHARSET=binary;
 11+CREATE INDEX /*i*/fls_key ON /*_*/file_locks_shared (fls_key);

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105819In LockManager:...aaron19:23, 11 December 2011

Comments

#Comment by 😂 (talk | contribs)   21:01, 12 December 2011

Should use $wgDBTableOptions

#Comment by Aaron Schulz (talk | contribs)   21:22, 12 December 2011

No, it *has* to be a table with row-level locking. This patch will not be added to the DB updater. It's for an optional locking class.

Status & tagging log