r105549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105548‎ | r105549 | r105550 >
Date:13:42, 8 December 2011
Author:siebrand
Status:resolved (Comments)
Tags:
Comment:
* remove unused message keys 'abusefilter-log-show-deleted', 'abusefilter-list-limit', 'abusefilter-links', 'abusefilter-tools-modifiertest-submit', 'abusefilter-tools', 'abusefilter-loglink'
* update message documentation for AbuseFilter. Still has some empty placeholders in qqq that I'm working on now. How wonderful would it be if all developers would just add that whenever they add keys? This saves so much time of translators and greatly improves translation quality.
Modified paths:
  • /trunk/extensions/AbuseFilter/AbuseFilter.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/AbuseFilter.i18n.php
——@@ -81,7 +81,6 @@
8282 'abusefilter-log-search-user' => 'User:',
8383 'abusefilter-log-search-filter' => 'Filter ID:',
8484 'abusefilter-log-search-title' => 'Title:',
85 - 'abusefilter-log-show-deleted' => 'Show hidden entries',
8685 'abusefilter-log-search-submit' => 'Search',
8786 'abusefilter-log-entry' => '$1: $2 triggered an abuse filter, performing the action "$3" on $4.
8887 Actions taken: $5;
——@@ -127,7 +126,6 @@
128127 'abusefilter-list-hitcount' => 'Hit count',
129128 'abusefilter-list-edit' => 'Edit',
130129 'abusefilter-list-details' => 'Details',
131 - 'abusefilter-list-limit' => 'Number per page:',
132130 'abusefilter-list-lastmodified' => 'Last modified',
133131 'abusefilter-hidden' => 'Private',
134132 'abusefilter-unhidden' => 'Public',
——@@ -136,10 +134,6 @@
137135 'abusefilter-disabled' => 'Disabled',
138136 'abusefilter-hitcount' => '$1 {{PLURAL:$1|hit|hits}}',
139137 'abusefilter-new' => 'Create a new filter',
140 - 'abusefilter-links' => 'Useful links:',
141 - 'abusefilter-tools-modifiertest-submit' => 'Test',
142 - 'abusefilter-tools' => 'Abuse filter tools',
143 - 'abusefilter-loglink' => 'View the abuse log',
144138 'abusefilter-return' => 'Return to filter management',
145139 'abusefilter-status-global' => 'Global',
146140
——@@ -259,7 +253,7 @@
260254 'abusefilter-edit-builder-op-bool-not' => 'Not (!)',
261255 'abusefilter-edit-builder-op-bool-and' => 'And (&)',
262256 'abusefilter-edit-builder-op-bool-or' => 'Or (|)',
263 - 'abusefilter-edit-builder-op-bool-xor' => 'XOR (^)',
 257+ 'abusefilter-edit-builder-op-bool-xor' => 'XOR (^)', // Message documentation complete up to here. Siebrand 2011-12-08.
264258 'abusefilter-edit-builder-group-misc' => 'Miscellaneous',
265259 'abusefilter-edit-builder-misc-in' => 'contained in string (in)',
266260 'abusefilter-edit-builder-misc-like' => 'Matches pattern (like)',
——@@ -578,7 +572,8 @@
579573 'abusefilter-log-details-vars' => 'Caption on a detail view of [[Special:AbuseLog]]',
580574 'abusefilter-log-details-private' => 'Header for private log details.',
581575 'abusefilter-log-details-ip' => 'Row label in private log details.',
582 - 'abusefilter-log-noactions' => '{{Identical|None}}',
 576+ 'abusefilter-log-noactions' => 'Tekst displayed in Special:AbuseLog when a rule was triggered, but no action was taken.
 577+{{Identical|None}}',
583578 'abusefilter-log-details-diff' => 'Header for differences between two edits in log details.',
584579 'abusefilter-log-linkoncontribs' => 'Link text added on [[Special:Contributions]] and other relevant special pages.',
585580 'abusefilter-log-linkoncontribs-text' => 'Title for link added on [[Special:Contributions]] and other relevant special pages.',
——@@ -595,49 +590,146 @@
596591 'abusefilter-logentry-unsuppress' => 'Log entry when unhiding an abuse filter log entry. Parameters:
597592 * $1 is a link to the log ID with the log ID as description.',
598593 'abusefilter-management' => 'Title of [[Special:AbuseFilter]]',
599 - 'abusefilter-list-id' => '{{Identical|Filter ID}}',
600 - 'abusefilter-list-status' => '{{Identical|Status}}',
601 - 'abusefilter-list-visibility' => '{{Identical|Visibility}}',
 594+ 'abusefilter-list-id' => 'Column header in abuse filter overview for the filter identifier.
 595+{{Identical|Filter ID}}',
 596+ 'abusefilter-list-status' => 'Column header in abuse filter overview for the filter status.
 597+{{Identical|Status}}',
 598+ 'abusefilter-list-public' => 'Column header in abuse filter overview for the public filter description.',
 599+ 'abusefilter-list-consequences' => 'Column header in abuse filter overview for the filter consequences.',
 600+ 'abusefilter-list-visibility' => 'Column header in abuse filter overview for the public filter visibility.
 601+{{Identical|Visibility}}',
 602+ 'abusefilter-list-hitcount' => 'Column header in abuse filter overview for the number of times the filter was triggered.',
602603 'abusefilter-list-edit' => 'Probably the verb "to edit" (instead of the noun "an edit").
603 -
604604 {{Identical|Edit}}',
605605 'abusefilter-list-details' => '{{Identical|Details}}',
606 - 'abusefilter-list-lastmodified' => '{{Identical|Last modified}}',
607 - 'abusefilter-hidden' => '{{Identical|Private}}',
608 - 'abusefilter-unhidden' => '{{Identical|Public}}',
609 - 'abusefilter-enabled' => '{{Identical|Enabled}}',
610 - 'abusefilter-deleted' => '{{Identical|Deleted}}',
611 - 'abusefilter-disabled' => '{{Identical|Disabled}}
612 -Used in [[Special:Preferences]].',
613 - 'abusefilter-new' => '',
614 - 'abusefilter-list-options-submit' => '{{Identical|Update}}',
615 - 'abusefilter-tools-reautoconfirm-user' => '{{Identical|User}}',
616 - 'abusefilter-reautoconfirm-none' => '{{gender}}
617 -* $1 is the target user name',
618 - 'abusefilter-reautoconfirm-done' => 'See {{msg-mw|group-autoconfirmed}} for concept translation. {{gender}}
619 -* (optional) $1 is the target user name',
620 - 'abusefilter-status' => 'Status information displayed on top of [[Special:AbuseFilter]].
621 -
622 -* <tt>$1</tt> – number of recent actions
623 -* <tt>$2</tt> – number of filter runs that reached the limit of $4 conditions (and have had to be terminated)
624 -* <tt>$3</tt> – percentage: $2 / $1 * 100
625 -* <tt>$4</tt> – maximum number of conditions allowed
626 -* <tt>$5</tt> – number of matched actions
627 -* <tt>$6</tt> – percentage: $5 / $1 * 100',
628 - 'abusefilter-edit-status-label' => '{{Identical|Statistics}}',
629 - 'abusefilter-edit-new' => '',
630 - 'abusefilter-edit-id' => '{{Identical|Filter ID}}',
631 - 'abusefilter-edit-flags' => '{{Identical|Flag}}',
632 - 'abusefilter-edit-lastmod-text' => 'This message is used on Special:AbuseFilter to indicate the last modified date, time and user for existing rules.
 606+ 'abusefilter-list-lastmodified' => 'Column header in abuse filter overview for the last modified timestamp for a filter.
 607+{{Identical|Last modified}}',
 608+ 'abusefilter-hidden' => 'Abuse filter status.
 609+{{Identical|Private}}',
 610+ 'abusefilter-unhidden' => 'Abuse filter status.
 611+{{Identical|Public}}',
 612+ 'abusefilter-enabled' => 'Abuse filter status.
 613+{{Identical|Enabled}}',
 614+ 'abusefilter-deleted' => 'Abuse filter status.
 615+{{Identical|Deleted}}',
 616+ 'abusefilter-disabled' => 'Abuse filter status.
 617+{{Identical|Disabled}}',
 618+ 'abusefilter-hitcount' => 'Indicates number of times an abuse filter was triggered. Parameters:
 619+* $1 is the number of hits.',
 620+ 'abusefilter-new' => 'Link text for creating a new abuse filter.',
 621+ 'abusefilter-return' => 'Link displayed when filtering abuse filters without results.',
 622+ 'abusefilter-status-global' => 'Abuse filter status. Means that it is active on all wikis in a farm.',
 623+ 'abusefilter-list-options' => 'Fieldset legend for abuse filter filter options.',
 624+ 'abusefilter-list-options-deleted' => 'Field label in filter form.',
 625+ 'abusefilter-list-options-deleted-only' => 'Radio button label in filter form.',
 626+ 'abusefilter-list-options-deleted-hide' => 'Radio button label in filter form.',
 627+ 'abusefilter-list-options-deleted-show' => 'Radio button label in filter form.',
 628+ 'abusefilter-list-options-disabled' => 'Field label in filter form.',
 629+ 'abusefilter-list-options-hidedisabled' => 'Radio button label in filter form.',
 630+ 'abusefilter-list-options-submit' => 'Submit button text in filter form to update a filtered list.
 631+{{Identical|Update}}',
 632+ 'abusefilter-tools-text' => 'Introduction test for abuse filter tools.',
 633+ 'abusefilter-tools-expr' => 'Fieldset legend for form to test a filter expression.',
 634+ 'abusefilter-tools-submitexpr' => 'Submit button text to test a filter expression.',
 635+ 'abusefilter-tools-reautoconfirm' => 'Fieldset legend for a form to add a user to the autoconfirmed group again.',
 636+ 'abusefilter-tools-reautoconfirm-user' => 'Field label. See {{msg-mw|group-autoconfirmed}} for concept translation.
 637+{{Identical|User}}',
 638+ 'abusefilter-tools-reautoconfirm-submit' => 'Submit button text to add a user to the autoconfirmed user group. See {{msg-mw|group-autoconfirmed}} for concept translation.',
 639+ 'abusefilter-reautoconfirm-none' => 'Error text in case a user has not had their autoconfirmed status revoked. See {{msg-mw|group-autoconfirmed}} for concept translation.
 640+* $1 is the target user name used for GENDER',
 641+ 'abusefilter-reautoconfirm-notallowed' => 'Error text when trying to perform an action the user cannot perform. See {{msg-mw|group-autoconfirmed}} for concept translation.',
 642+ 'abusefilter-reautoconfirm-done' => 'See {{msg-mw|group-autoconfirmed}} for concept translation.
 643+* $1 is the target user name (optional, used for GENDER).',
 644+ 'abusefilter-status' => 'Status information displayed on top of [[Special:AbuseFilter]]. Parameters:
 645+* $1 is the number of recent actions
 646+* $2 is the number of filter runs that reached the limit of $4 conditions (and have had to be terminated)
 647+* $3 is a percentage: $2 / $1 * 100
 648+* $4 is the maximum number of conditions allowed
 649+* $5 is the number of matched actions
 650+* $6 is a percentage: $5 / $1 * 100',
 651+ 'abusefilter-edit-subtitle' => 'Page subtitle when editing an abuse filter.',
 652+ 'abusefilter-edit-oldwarning' => 'Warning displayed when editing an older version of a filter.',
 653+ 'abusefilter-edit-status-label' => 'Field label for abuse filter statistics.
 654+{{Identical|Statistics}}',
 655+ 'abusefilter-edit-new' => 'Field value in case an edited filter is new.',
 656+ 'abusefilter-edit-save' => 'Submit button text to save a filter.',
 657+ 'abusefilter-edit-id' => 'Field label for filter identifier.
 658+{{Identical|Filter ID}}',
 659+ 'abusefilter-edit-description' => 'Field label for publicly viewable abuse filter description.',
 660+ 'abusefilter-edit-flags' => 'Field label for abuse filter flags (checkboxes for "hidden", "enabled" and "deleted").
 661+{{Identical|Flag}}',
 662+ 'abusefilter-edit-enabled' => 'Checkbox label for a filter flag.',
 663+ 'abusefilter-edit-deleted' => 'Checkbox label for a filter flag.',
 664+ 'abusefilter-edit-hidden' => 'Checkbox label for a filter flag.',
 665+ 'abusefilter-edit-rules' => 'Field label for filter rules.',
 666+ 'abusefilter-edit-notes' => 'Field label for filter notes.',
 667+ 'abusefilter-edit-lastmod' => 'Field label for filter\'s last modified timestamp.',
 668+ 'abusefilter-edit-lastmod-text' => 'This message is used on Special:AbuseFilter to indicate the last modified date, time and user for existing rules. Parameters:
633669 * $1 is a time and date (duplicated in $3 and $4)
634670 * $2 is a link to a user page with a user name as link text, followed by a series of related links
635671 * $3 is the date
636672 * $4 is the time
637673 * $5 is the user name which can be used with GENDER',
 674+ 'abusefilter-edit-hitcount' => '',
 675+ 'abusefilter-edit-consequences' => '',
 676+ 'abusefilter-edit-action-warn' => '',
 677+ 'abusefilter-edit-action-disallow' => '',
 678+ 'abusefilter-edit-action-flag' => '',
 679+ 'abusefilter-edit-action-blockautopromote' => '',
 680+ 'abusefilter-edit-action-degroup' => '',
 681+ 'abusefilter-edit-action-block' => '',
 682+ 'abusefilter-edit-action-throttle' => '',
 683+ 'abusefilter-edit-action-rangeblock' => '',
 684+ 'abusefilter-edit-action-tag' => '',
 685+ 'abusefilter-edit-throttle-count' => '',
 686+ 'abusefilter-edit-throttle-period' => '',
 687+ 'abusefilter-edit-throttle-seconds' => '',
638688 'abusefilter-edit-throttle-groups' => 'Could you please go over the "throttle" concept? It is polysemic in Spanish. I need definition.',
 689+ 'abusefilter-edit-warn-message' => '',
 690+ 'abusefilter-edit-warn-other' => '',
 691+ 'abusefilter-edit-warn-other-label' => '',
639692 'abusefilter-edit-warn-actions' => '{{Identical|Action}}',
 693+ 'abusefilter-edit-warn-preview' => '',
 694+ 'abusefilter-edit-warn-edit' => '',
 695+ 'abusefilter-edit-tag-tag' => '',
 696+ 'abusefilter-edit-denied' => '',
 697+ 'abusefilter-edit-main' => '',
 698+ 'abusefilter-edit-done-subtitle' => '',
 699+ 'abusefilter-edit-done' => '',
 700+ 'abusefilter-edit-badsyntax' => '',
 701+ 'abusefilter-edit-restricted' => '',
 702+ 'abusefilter-edit-viewhistory' => '',
640703 'abusefilter-edit-history' => '{{Identical|History}}',
 704+ 'abusefilter-edit-check' => '',
 705+ 'abusefilter-edit-badfilter' => '',
 706+ 'abusefilter-edit-revert' => '',
641707 'abusefilter-edit-tools' => '{{Identical|Tools}}',
 708+ 'abusefilter-edit-test-link' => '',
 709+ 'abusefilter-edit-global' => '',
 710+ 'abusefilter-edit-export' => '',
 711+ 'abusefilter-edit-syntaxok' => '',
 712+ 'abusefilter-edit-syntaxerr' => '',
 713+ 'abusefilter-edit-bad-tags' => '',
 714+ 'abusefilter-edit-notallowed' => '',
 715+ 'abusefilter-edit-builder-select' => '',
 716+ 'abusefilter-edit-builder-group-op-arithmetic' => '',
 717+ 'abusefilter-edit-builder-op-arithmetic-addition' => '',
 718+ 'abusefilter-edit-builder-op-arithmetic-subtraction' => '',
 719+ 'abusefilter-edit-builder-op-arithmetic-multiplication' => '',
 720+ 'abusefilter-edit-builder-op-arithmetic-divide' => '',
 721+ 'abusefilter-edit-builder-op-arithmetic-modulo' => '',
 722+ 'abusefilter-edit-builder-op-arithmetic-pow' => '',
 723+ 'abusefilter-edit-builder-group-op-comparison' => '',
 724+ 'abusefilter-edit-builder-op-comparison-equal' => '',
 725+ 'abusefilter-edit-builder-op-comparison-notequal' => '',
 726+ 'abusefilter-edit-builder-op-comparison-lt' => '',
 727+ 'abusefilter-edit-builder-op-comparison-gt' => '',
 728+ 'abusefilter-edit-builder-op-comparison-lte' => '',
 729+ 'abusefilter-edit-builder-op-comparison-gte' => '',
 730+ 'abusefilter-edit-builder-group-op-bool' => '',
 731+ 'abusefilter-edit-builder-op-bool-not' => '',
 732+ 'abusefilter-edit-builder-op-bool-and' => '',
 733+ 'abusefilter-edit-builder-op-bool-or' => '',
642734 'abusefilter-edit-builder-op-bool-xor' => '{{optional}}',
643735 'abusefilter-edit-builder-misc-in' => 'Do not translate "(in)"',
644736 'abusefilter-edit-builder-misc-like' => 'Do not translate "(like)"',

Follow-up revisions

RevisionCommit summaryAuthorDate
r105554Follow-up r105549: fix typo pointed out by Santhosh.siebrand15:00, 8 December 2011
r107189Follow-up r105549: revert incorrect removal of key 'abusefilter-list-limit'.siebrand00:06, 24 December 2011
r107190Follow-up r105549, r107189: rebuild AbuseFilter.i18n.php.siebrand00:11, 24 December 2011

Comments

#Comment by Santhosh.thottingal (talk | contribs)   14:43, 8 December 2011

a small typo here: abusefilter-log-noactions' => 'Tekst display

#Comment by Johnduhart (talk | contribs)   20:17, 23 December 2011

abusefilter-list-limit is still be used.

#Comment by Siebrand (talk | contribs)   00:04, 24 December 2011

Thanks for spotting that. Fixing...

Status & tagging log