r105524 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105523‎ | r105524 | r105525 >
Date:09:13, 8 December 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Followup r102182 - account for old jquery
Modified paths:
  • /trunk/extensions/Translate/resources/ext.translate.messagetable.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/resources/ext.translate.messagetable.js
@@ -29,7 +29,12 @@
3030 format: "json"
3131 };
3232 $b.val( mw.msg( "translate-messagereview-progress" ) );
33 - $b.prop( "disabled", true );
 33+ // BC for MW < 1.18
 34+ if ( typeof $b.prop === "undefined" ) {
 35+ $b.attr( "disabled", "disabled );
 36+ } else {
 37+ $b.prop( "disabled", true );
 38+ }
3439 $.post( mw.util.wikiScript( "api" ), params, successFunction ).fail( failFunction );
3540 } );
3641 } );

Follow-up revisions

RevisionCommit summaryAuthorDate
r105561Followup r105524 fix syntax errornikerabbit16:29, 8 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102182Hopefully fix JS issues in 1.17nikerabbit15:38, 6 November 2011

Status & tagging log