r105488 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105487‎ | r105488 | r105489 >
Date:23:34, 7 December 2011
Author:seanheavey
Status:resolved (Comments)
Tags:
Comment:
bugzilla bugs 32818 32846 32834 32831 32847
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -70,19 +70,19 @@
7171 'articlefeedbackv5-bucket2-question-label' => 'Question',
7272 'articlefeedbackv5-bucket2-problem-label' => 'Problem',
7373 'articlefeedbackv5-bucket2-praise-label' => 'Praise',
74 - 'articlefeedbackv5-bucket2-suggestion-comment-default' => 'Make a suggestion. How can this article be improved?',
 74+ 'articlefeedbackv5-bucket2-suggestion-comment-default' => 'Make a suggestion! How can this article be improved?',
7575 'articlefeedbackv5-bucket2-question-comment-default' => 'Ask a question about this article.',
76 - 'articlefeedbackv5-bucket2-problem-comment-default' => 'Report a problem. How can this article be improved?',
77 - 'articlefeedbackv5-bucket2-praise-comment-default' => 'What do you like most? Share your praise with the editors',
 76+ 'articlefeedbackv5-bucket2-problem-comment-default' => 'Report a problem! How can this article be improved?',
 77+ 'articlefeedbackv5-bucket2-praise-comment-default' => 'What do you like most? Share your praise with the editors.',
7878 'articlefeedbackv5-bucket2-form-submit' => 'Post your feedback',
7979 /* Option 3 (single rating) */
8080 'articlefeedbackv5-bucket3-title' => 'Help improve this article',
81 - 'articlefeedbackv5-bucket3-rating-question' => 'How would you rate it, overall?',
82 - 'articlefeedbackv5-bucket3-rating-tooltip-1' => 'Bad',
83 - 'articlefeedbackv5-bucket3-rating-tooltip-2' => 'Poor',
 81+ 'articlefeedbackv5-bucket3-rating-question' => 'Is this article helpful?',
 82+ 'articlefeedbackv5-bucket3-rating-tooltip-1' => 'Not helpful at all',
 83+ 'articlefeedbackv5-bucket3-rating-tooltip-2' => 'Not Very Helpful',
8484 'articlefeedbackv5-bucket3-rating-tooltip-3' => 'Average',
85 - 'articlefeedbackv5-bucket3-rating-tooltip-4' => 'Good',
86 - 'articlefeedbackv5-bucket3-rating-tooltip-5' => 'Very good',
 85+ 'articlefeedbackv5-bucket3-rating-tooltip-4' => 'Helpful',
 86+ 'articlefeedbackv5-bucket3-rating-tooltip-5' => 'Very helpful',
8787 'articlefeedbackv5-bucket3-clear-rating' => 'Remove this rating',
8888 'articlefeedbackv5-bucket3-comment-default' => 'Add a comment. How can this article be improved?',
8989 'articlefeedbackv5-bucket3-form-submit' => 'Post your feedback',
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -466,6 +466,7 @@
467467 .articleFeedbackv5-panel h2 {
468468 float: left;
469469 border: none;
 470+ font-weight: bold;
470471 }
471472 .articleFeedbackv5-tooltip-wrap {
472473 float: right;
@@ -610,9 +611,8 @@
611612 }
612613
613614 .articleFeedbackv5-ui .articleFeedbackv5-disclosure {
614 - float: right;
615615 width: 335px;
616 - margin: 18px 0 0;
 616+ margin: 10px 0;
617617 }
618618
619619 .articleFeedbackv5-ui .articleFeedbackv5-disclosure p {
@@ -621,7 +621,7 @@
622622 }
623623
624624 .articleFeedbackv5-ui .articleFeedbackv5-submit {
625 - float: left;
 625+ /*float: left;*/
626626 height: 35px !important;
627627 width: auto;
628628 text-align: center;
@@ -654,9 +654,9 @@
655655 text-align: center;
656656 color: #fff;
657657 /*text-shadow: 1px 1px 1px #000;*/
658 - padding: 1px 30px 0 0;
 658+ /*padding: 1px 30px 0 0;*/
659659 /* @embed */
660 - background: url(images/bg-submit-icon.png) right center no-repeat;
 660+ /*background: url(images/bg-submit-icon.png) right center no-repeat;*/
661661 }
662662
663663 /*** Option 2 ***/

Comments

#Comment by Nikerabbit (talk | contribs)   07:16, 8 December 2011

Why title case and commenting out instead of removing?

#Comment by Catrope (talk | contribs)   17:03, 12 December 2011

Please be a bit more descriptive in your commit summaries. Briefly explain what the bug was, and explain how you fixed it if that's non-obvious from the code.

+	'articlefeedbackv5-bucket3-rating-tooltip-2' => 'Not Very Helpful',

Like Nikerabbit Said, Please Don't Use Title Case In Interface Messages Like That. OK otherwise.

Status & tagging log