r105467 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105466‎ | r105467 | r105468 >
Date:22:22, 7 December 2011
Author:yaron
Status:ok
Tags:
Comment:
Follow-up to r105251 - method was only added in MW 1.19
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/SemanticMediaWiki.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/SemanticMediaWiki.hooks.php
@@ -24,9 +24,12 @@
2525 * @return true
2626 */
2727 public static function onSchemaUpdate( /* DatabaseUpdater */ $updater = null ) {
28 - // $updater can be null in MW 1.16.x. This can be removed when dropping 1.16 compat.
 28+ // $updater can be null in MW 1.16.
2929 if ( !is_null( $updater ) ) {
30 - $updater->addPostDatabaseUpdateMaintenance( 'SMWSetupScript' );
 30+ // Method was added in MW 1.19.
 31+ if ( is_callable( array( $updater, 'addPostDatabaseUpdateMaintenance' ) ) ) {
 32+ $updater->addPostDatabaseUpdateMaintenance( 'SMWSetupScript' );
 33+ }
3134 }
3235
3336 return true;

Follow-up revisions

RevisionCommit summaryAuthorDate
r105496follow up to r105467jeroendedauw00:00, 8 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105251have the setup script run via the db update hook, so people do not have to do...jeroendedauw23:54, 5 December 2011

Status & tagging log