r105438 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105437‎ | r105438 | r105439 >
Date:16:47, 7 December 2011
Author:jeroendedauw
Status:ok (Comments)
Tags:
Comment:
minor fix
Modified paths:
  • /trunk/extensions/UploadWizard/includes/UploadWizardCampaign.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/includes/UploadWizardCampaign.php
@@ -300,6 +300,11 @@
301301 $defaultConfig = self::getDefaultConfig();
302302
303303 foreach ( $config as $settingName => &$settingValue ) {
 304+ // This can happen when a campaign was created with an option that has been removed from the extension.
 305+ if ( !array_key_exists( $settingName, $defaultConfig ) ) {
 306+ continue;
 307+ }
 308+
304309 if ( is_array( $defaultConfig[$settingName]['default'] ) && !is_array( $settingValue ) ) {
305310 $parts = explode( '|', $settingValue );
306311 $settingValue = array();

Comments

#Comment by NeilK (talk | contribs)   22:22, 7 December 2011

good catch

Status & tagging log