r105392 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105391‎ | r105392 | r105393 >
Date:00:30, 7 December 2011
Author:khorn
Status:ok
Tags:
Comment:
Fixes the problem of original referrers not making it to the logs and minfraud, on forms which use the DonationInterface API to fetch the GlobalCollect iframe.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/donation.api.php (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/gc.js (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects.js (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/gc.js
@@ -53,6 +53,7 @@
5454 'utm_source': $( "input[name='utm_source']" ).val(),
5555 'utm_campaign': $( "input[name='utm_campaign']" ).val(),
5656 'utm_medium': $( "input[name='utm_medium']" ).val(),
 57+ 'referrer': $( "input[name='referrer']" ).val(),
5758 'format': 'json'
5859 };
5960 $.ajax( {
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects.js
@@ -55,6 +55,7 @@
5656 'utm_source': $( "input[name='utm_source']" ).val(),
5757 'utm_campaign': $( "input[name='utm_campaign']" ).val(),
5858 'utm_medium': $( "input[name='utm_medium']" ).val(),
 59+ 'referrer': $( "input[name='referrer']" ).val(),
5960 'format': 'json'
6061 };
6162 $.ajax( {
Index: trunk/extensions/DonationInterface/gateway_common/donation.api.php
@@ -112,6 +112,7 @@
113113 'utm_source' => $this->defineParam( false ),
114114 'utm_campaign' => $this->defineParam( false ),
115115 'utm_medium' => $this->defineParam( false ),
 116+ 'referrer' => $this->defineParam( false ),
116117 );
117118 }
118119
@@ -180,6 +181,7 @@
181182 'utm_source' => 'Tracking variable',
182183 'utm_campaign' => 'Tracking variable',
183184 'utm_medium' => 'Tracking variable',
 185+ 'referrer' => 'Original referrer',
184186 );
185187 }
186188

Follow-up revisions

RevisionCommit summaryAuthorDate
r105401MFT r105361, r105371, r105392khorn01:11, 7 December 2011

Status & tagging log