r105326 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105325‎ | r105326 | r105327 >
Date:18:41, 6 December 2011
Author:rsterbin
Status:ok (Comments)
Tags:
Comment:
Switched to use the button disable methods rather than option settings; I *think* this will fix the double-submit bug, but I never got it consistently, so pushing out for Yoni to test.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -631,6 +631,7 @@
632632 // Attach the submit
633633 $block.find( '.articleFeedbackv5-submit' )
634634 .click( function ( e ) {
 635+ console.log( 'got to click event' );
635636 e.preventDefault();
636637 $.articleFeedbackv5.submitForm();
637638 } );
@@ -2028,9 +2029,9 @@
20292030 */
20302031 $.articleFeedbackv5.enableSubmission = function ( state ) {
20312032 if ( state ) {
2032 - $.articleFeedbackv5.find( '.articleFeedbackv5-submit' ).button( { 'disabled': false } );
 2033+ $.articleFeedbackv5.find( '.articleFeedbackv5-submit' ).button( 'enable' );
20332034 } else {
2034 - $.articleFeedbackv5.find( '.articleFeedbackv5-submit' ).button( { 'disabled': true } );
 2035+ $.articleFeedbackv5.find( '.articleFeedbackv5-submit' ).button( 'disable' );
20352036 }
20362037 var bucket = $.articleFeedbackv5.currentBucket();
20372038 if ( 'enableSubmission' in bucket ) {

Comments

#Comment by Catrope (talk | contribs)   15:29, 12 December 2011
+						console.log( 'got to click event' );

Was removed in a later revision.

Status & tagging log