| Index: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js |
| — | — | @@ -18,10 +18,18 @@ |
| 19 | 19 | |
| 20 | 20 | /* Setup for feedback links */ |
| 21 | 21 | |
| 22 | | -// Only track users who have been assigned to the tracking group |
| 23 | | -var useClickTracking = 'track' === mw.user.bucket( |
| 24 | | - 'ext.articleFeedbackv5-tracking', mw.config.get( 'wgArticleFeedbackv5Tracking' ) |
| 25 | | -); |
| | 22 | +// Only track users who have been assigned to the tracking group; don't bucket |
| | 23 | +// at all if we're set to always ignore or always track. |
| | 24 | +var useClickTracking = function () { |
| | 25 | + var b = mw.config.get( 'wgArticleFeedbackv5Tracking' ); |
| | 26 | + if ( b.buckets.ignore == 100 && b.buckets.track == 0 ) { |
| | 27 | + return false; |
| | 28 | + } |
| | 29 | + if ( b.buckets.ignore == 0 && b.buckets.track == 100 ) { |
| | 30 | + return true; |
| | 31 | + } |
| | 32 | + return ( 'track' === mw.user.bucket( 'ext.articleFeedbackv5-tracking', b ) ); |
| | 33 | +}(); |
| 26 | 34 | |
| 27 | 35 | // Info about each of the links |
| 28 | 36 | var linkInfo = { |
| Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.php |
| — | — | @@ -91,8 +91,8 @@ |
| 92 | 92 | // this number to ensure the new odds are applied to everyone, not just people who have yet to |
| 93 | 93 | // be placed in a bucket. |
| 94 | 94 | 'buckets' => array( |
| 95 | | - 'ignore' => 0, |
| 96 | | - 'track' => 100, |
| | 95 | + 'ignore' => 100, |
| | 96 | + 'track' => 0, |
| 97 | 97 | ), |
| 98 | 98 | // This version number is added to all tracking event names, so that changes in the software |
| 99 | 99 | // don't corrupt the data being collected. Bump this when you want to start a new "experiment". |