r105191 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105190‎ | r105191 | r105192 >
Date:17:10, 5 December 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix noise in running dumpInterwiki.php

Notice: Undefined offset: 0 in /home/wikipedia/common/php-1.18/maintenance/dumpInterwiki.php on line 234
PHP Notice: Undefined offset: 0 in /home/wikipedia/common/php-1.18/maintenance/dumpInterwiki.php on line 234
Modified paths:
  • /trunk/extensions/WikimediaMaintenance/dumpInterwiki.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikimediaMaintenance/dumpInterwiki.php
——@@ -259,8 +259,9 @@
260260 * @param $source
261261 */
262262 function makeLink( $entry, $source ) {
263 - if ( isset( $this->prefixRewrites[$source] ) && isset( $this->prefixRewrites[$source][$entry[0]] ) )
 263+ if ( isset( $this->prefixRewrites[$source] ) && isset( $entry[0] ) && isset( $this->prefixRewrites[$source][$entry[0]] ) ) {
264264 $entry[0] = $this->prefixRewrites[$source][$entry[0]];
 265+ }
265266
266267 if ( !array_key_exists( "iw_prefix", $entry ) ) {
267268 $entry = array( "iw_prefix" => $entry[0], "iw_url" => $entry[1], "iw_local" => $entry[2] );

Follow-up revisions

RevisionCommit summaryAuthorDate
r105192MFT r105191reedy17:13, 5 December 2011

Status & tagging log