r105183 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105182‎ | r105183 | r105184 >
Date:15:20, 5 December 2011
Author:catrope
Status:deferred
Tags:
Comment:
AFTv5: Add some @embed and fix whitespace
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
——@@ -10,7 +10,7 @@
1111
1212 @media print {
1313 .articleFeedbackv5 {
14 - display:none;
 14+ display: none;
1515 }
1616 }
1717
——@@ -479,11 +479,13 @@
480480 }
481481
482482 .articleFeedbackv5-tooltip .tooltip-top {
 483+ /* @embed */
483484 background: url(images/bg-tooltip-top.png);
484485 height: 11px;
485486 }
486487
487488 .articleFeedbackv5-tooltip .tooltip-repeat {
 489+ /* @embed */
488490 background: url(images/bg-tooltip.png) repeat-y;
489491 padding: 0 20px 1px;
490492 margin: 0;
——@@ -504,6 +506,7 @@
505507 }
506508
507509 .articleFeedbackv5-tooltip .tooltip-bottom {
 510+ /* @embed */
508511 background: url(images/bg-tooltip-bottom.png);
509512 height: 26px;
510513 }
——@@ -512,6 +515,7 @@
513516 display: block;
514517 height: 27px;
515518 width: 26px;
 519+ /* @embed */
516520 background: url(images/bg-tooltip-trigger.png) no-repeat;
517521 float: right;
518522 position: relative;
——@@ -519,6 +523,7 @@
520524 }
521525
522526 .articleFeedbackv5-tooltip-trigger:hover {
 527+ /* @embed */
523528 background: url(images/bg-tooltip-trigger-hov.png) no-repeat;
524529 cursor: pointer;
525530 text-decoration: none;
——@@ -558,6 +563,7 @@
559564 text-align: center;
560565 color: #333;
561566 font-weight: bold;
 567+ /* @embed */
562568 background: url(images/bg-button-disable.png) repeat-x;
563569 -moz-border-radius: 3px;
564570 -webkit-border-radius: 3px;
——@@ -569,6 +575,7 @@
570576 }
571577
572578 .articleFeedbackv5-ui .buttons .articleFeedbackv5-button-placeholder:hover {
 579+ /* @embed */
573580 background: url(images/bg-button-hov.png) repeat-x;
574581 cursor: pointer;
575582 color: #333;
——@@ -576,6 +583,7 @@
577584
578585 .articleFeedbackv5-ui .buttons .articleFeedbackv5-button-placeholder-active,
579586 .articleFeedbackv5-ui .buttons .articleFeedbackv5-button-placeholder-active:hover {
 587+ /* @embed */
580588 background: url(images/bg-button.png) repeat-x;
581589 color: #fff;
582590 }
——@@ -614,6 +622,7 @@
615623 width: auto;
616624 text-align: center;
617625 padding: 0 10px;
 626+ /* @embed */
618627 background: url(images/bg-submit.png) repeat-x !important;
619628 margin: 10px 30px 0 0 !important;
620629 border: none !important;
——@@ -642,6 +651,7 @@
643652 color: #fff;
644653 /*text-shadow: 1px 1px 1px #000;*/
645654 padding: 1px 30px 0 0;
 655+ /* @embed */
646656 background: url(images/bg-submit-icon.png) right center no-repeat;
647657 }
648658
——@@ -680,6 +690,7 @@
681691
682692 .articleFeedbackv5-tags ul li.active .tag-selector {
683693 position: absolute;
 694+ /* @embed */
684695 background: url(images/bg-tag-active.png) no-repeat center bottom;
685696 display: block;
686697 width: 15px;
——@@ -703,18 +714,22 @@
704715 }
705716
706717 .articleFeedbackv5-tags ul li .articleFeedbackv5-bucket2-suggestion-label {
 718+ /* @embed */
707719 background: url(images/bg-tag-suggestion-on.png) no-repeat 0 center;
708720 }
709721
710722 .articleFeedbackv5-tags ul li .articleFeedbackv5-bucket2-question-label {
 723+ /* @embed */
711724 background: url(images/bg-tag-question-on.png) no-repeat 0 center;
712725 }
713726
714727 .articleFeedbackv5-tags ul li .articleFeedbackv5-bucket2-problem-label {
 728+ /* @embed */
715729 background: url(images/bg-tag-problem-on.png) no-repeat 0 center;
716730 }
717731
718732 .articleFeedbackv5-tags ul li .articleFeedbackv5-bucket2-praise-label {
 733+ /* @embed */
719734 background: url(images/bg-tag-praise-on.png) no-repeat 0 center;
720735 }
721736
——@@ -740,10 +755,12 @@
741756
742757 /*** Option 3 ***/
743758 .articleFeedbackv5-rating-new .articleFeedbackv5-rating-label {
 759+ /* @embed */
744760 background: url(images/bg-rating-off.png) no-repeat;
745761 }
746762
747763 .articleFeedbackv5-rating-new .articleFeedbackv5-rating-label.active {
 764+ /* @embed */
748765 background: url(images/bg-rating-on.png) no-repeat;
749766 }
750767
——@@ -785,9 +802,11 @@
786803 text-indent: -90000px;
787804 width: 23px;
788805 height: 22px;
 806+ /* @embed */
789807 background: url(images/bg-close-off.png) no-repeat !important;
790808 }
791809 body .ui-dialog .ui-icon-closethick:hover {
 810+ /* @embed */
792811 background: url(images/bg-close-hov.png) no-repeat !important;
793812 border: none !important;
794813 }
——@@ -826,6 +845,7 @@
827846 padding: 0 0 0 24px;
828847 margin: 0 9px 0 0;
829848 height: 25px;
 849+ /* @embed */
830850 background: url(images/bg-confirmation-thanks.png) 0 center no-repeat;
831851 }
832852 .articleFeedbackv5-confirmation-panel .articleFeedbackv5-panel-leftContent .articleFeedbackv5-confirmation-learnHow {
——@@ -837,6 +857,7 @@
838858 width: auto;
839859 text-align: center;
840860 padding: 0 10px;
 861+ /* @embed */
841862 background: url(images/bg-submit.png) repeat-x !important;
842863 margin: 10px 30px 0 0 !important;
843864 border: none !important;
——@@ -866,6 +887,7 @@
867888 /*text-shadow: 1px 1px 1px #000;*/
868889 padding: 1px 30px 0 0;
869890 margin: 8px 0 0;
 891+ /* @embed */
870892 background: url(images/bg-submit-icon.png) right center no-repeat;
871893 }
872894
——@@ -910,6 +932,7 @@
911933 display: block;
912934 height: 27px;
913935 width: 26px;
 936+ /* @embed */
914937 background: url(images/bg-close-off.png) no-repeat !important;
915938 float: right;
916939 position: relative;
——@@ -918,8 +941,8 @@
919942 }
920943
921944 .articleFeedbackv5-clear-trigger:hover {
 945+ /* @embed */
922946 background: url(images/bg-close-hov.png) no-repeat !important;
923947 cursor: pointer;
924948 text-decoration: none;
925949 }
926 -

Status & tagging log