r105182 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105181‎ | r105182 | r105183 >
Date:15:07, 5 December 2011
Author:rsterbin
Status:ok
Tags:
Comment:
Added message for Option 3 tooltip; bug fix to make it show up (incorrect class name)
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -82,6 +82,7 @@
8383 'articlefeedbackv5-bucket3-rating-tooltip-3' => 'Average',
8484 'articlefeedbackv5-bucket3-rating-tooltip-4' => 'Good',
8585 'articlefeedbackv5-bucket3-rating-tooltip-5' => 'Very Good',
 86+ 'articlefeedbackv5-bucket3-clear-rating' => 'Remove this rating',
8687 'articlefeedbackv5-bucket3-comment-default' => 'Add a comment. How can this article be improved?',
8788 'articlefeedbackv5-bucket3-form-submit' => 'Post your feedback',
8889 /* Option 4 (just a big glossy edit button and some teaser text) */
@@ -285,6 +286,7 @@
286287 'articlefeedbackv5-bucket3-rating-tooltip-3' => 'This is the text that appears under the rating stars when you roll over star #3',
287288 'articlefeedbackv5-bucket3-rating-tooltip-4' => 'This is the text that appears under the rating stars when you roll over star #4',
288289 'articlefeedbackv5-bucket3-rating-tooltip-5' => 'This is the text that appears under the rating stars when you roll over star #5',
 290+ 'articlefeedbackv5-bucket3-clear-rating' => 'This is the tooltip that appears when you roll over the ratings-clear trash can icon',
289291 'articlefeedbackv5-bucket3-comment-default' => 'This is the grey default text that appears in the comment box.',
290292 'articlefeedbackv5-bucket3-form-submit' => 'This is the contents of the submit button for option 3 (a 1-5 star rating selector and a comment box)',
291293 /* Option 4 (just a big glossy edit button and some teaser text) */
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -767,7 +767,7 @@
768768 <div class="articleFeedbackv5-rating articleFeedbackv5-rating-new">\
769769 <input type="hidden" name="rating" value="0">\
770770 <div class="bucket3-rating">\
771 - <div class="articleFeedback-rating-labels articleFeedback-visibleWith-form">\
 771+ <div class="articleFeedbackv5-rating-labels articleFeedbackv5-visibleWith-form">\
772772 <div class="articleFeedbackv5-rating-label" rel="1"></div>\
773773 <div class="articleFeedbackv5-rating-label" rel="2"></div>\
774774 <div class="articleFeedbackv5-rating-label" rel="3"></div>\
@@ -824,10 +824,19 @@
825825
826826 // Fill in the rating clear title
827827 var clear_msg = mw.msg( 'articlefeedbackv5-bucket3-clear-rating' );
828 - $block.find( '.articleFeedback-rating-clear' )
829 - .attr( 'original-title', clear_msg ) // not sure what this is for... Sean?
 828+ $block.find( '.articleFeedbackv5-rating-clear' )
830829 .attr( 'title', clear_msg );
831830
 831+ // Activate tooltips
 832+ $block.find( '[title]' )
 833+ .tipsy( {
 834+ 'gravity': 'sw',
 835+ 'center': false,
 836+ 'fade': true,
 837+ 'delayIn': 300,
 838+ 'delayOut': 100
 839+ } );
 840+
832841 // Fill in the disclosure text
833842 $block.find( '.articlefeedbackv5-shared-on-feedback' )
834843 .html( $.articleFeedbackv5.buildLink(

Status & tagging log