r105167 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105166‎ | r105167 | r105168 >
Date:12:21, 5 December 2011
Author:raymond
Status:resolved
Tags:
Comment:
r104375: Consistency tweaks in preparation for adding extension to translatewiki.net:
* Move message documentation to the 'qqq' section
* Fix encoding per Nikerabbit's CR
* Fix a typo per Nikerabbit's CR
* Extension credits:
** Put authors into an array
** Fix description message key and move the description to the i18n file
* Remove a trailing ?>
* Some spaces2tabs
Modified paths:
  • /trunk/extensions/SemanticWebBrowser/SWB_Settings.php (modified) (history)
  • /trunk/extensions/SemanticWebBrowser/SemanticWebBrowser.alias.php (modified) (history)
  • /trunk/extensions/SemanticWebBrowser/SemanticWebBrowser.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticWebBrowser/SWB_Settings.php
@@ -21,9 +21,9 @@
2222 'path' => __FILE__,
2323 'name' => 'Semantic Web Browser',
2424 'version' => '0.2',
25 - 'author' => 'Benedikt Kaempgen, Anna Kantorovitch.',
 25+ 'author' => array( 'Benedikt Kaempgen', 'Anna Kantorovitch' ),
2626 'url' => 'http://semantic-mediawiki.org',
27 - 'descriptionmsg' => 'This extension adds a special page (and later a factbox) Browse Wiki and Semantic Web.'
 27+ 'descriptionmsg' => 'swb_desc'
2828 );
2929
3030 /**
@@ -34,6 +34,4 @@
3535 $swbgToolboxBrowseSemWeb = true;
3636
3737 // load global constants and setup functions
38 -require_once( $swbgIP.'SemanticWebBrowser.php' );
39 -
40 -?>
\ No newline at end of file
 38+require_once( $swbgIP.'SemanticWebBrowser.php' );
\ No newline at end of file
Index: trunk/extensions/SemanticWebBrowser/SemanticWebBrowser.alias.php
@@ -2,7 +2,7 @@
33 /**
44 * Aliases for special pages
55 *
6 - * @author Anna Kantorovitch and Benedikt K�mpgen
 6+ * @author Anna Kantorovitch and Benedikt Kämpgen
77 * @ingroup Extensions
88 * @ingroup SWBLanguage
99 */
@@ -11,5 +11,5 @@
1212 /** English (English) */
1313
1414 $specialPageAliases['en'] = array(
15 - 'BrowseWiki' => array( 'BrowseWiki' ),
 15+ 'BrowseWiki' => array( 'BrowseWiki' ),
1616 );
\ No newline at end of file
Index: trunk/extensions/SemanticWebBrowser/SemanticWebBrowser.i18n.php
@@ -1,28 +1,40 @@
22 <?php
33 /**
44 * Internationalization file for Semantic WebBrowser
5 - *@author Anna Kantorovitch and Benedikt K�mpgen
 5+ * @author Anna Kantorovitch and Benedikt Kämpgen
66 * @ingroup Language
77 * @ingroup SWBLanguage
88 */
99
10 -
1110 /** English
1211 *
1312 */
1413 $messages['en'] = array(
 14+ 'browsewiki' => 'Browse Wiki & Semantic Web',
 15+ 'swb_desc' => 'Adds a special page [[Special:BrowseWiki|Browse Wiki & Semantic Web]]',
 16+ 'swb_browse_article' => 'Enter the name of the page to start semantic browsing from.'
 17+ 'swb_browse_go' => 'Go',
 18+ 'swb_browse_show_incoming' => 'show incoming properties that link here',
 19+ 'swb_browse_hide_incoming' => 'hide incoming properties that link here',
 20+ 'swb_browse_no_outgoing' => 'This page has no properties.',
 21+ 'swb_browse_no_incoming' => 'No properties link to this page.',
 22+ 'swb_inverse_label_property' => 'Inverse property label',
 23+ 'swb_inverse_label_default' => '$1 of',
 24+ 'swb_browse_more' => '...',
 25+);
1526
16 - // Messages for the browsing semantic Web special
17 -
18 - 'browsewiki' => 'Browse Wiki & Semantic Web', #title of the SWB page
19 - 'swb_browse_semantic_web' => 'Browse Wiki & Semantic Web', #title for browsing
20 - 'swb_browse_article' => 'Enter the name of the page to start semantic browsing from.',#text above "go"window
21 - 'swb_browse_go' => 'Go', #title of button "go"
22 - 'swb_browse_show_incoming' => 'show incoming properties that link here', #title of properties
23 - 'swb_browse_hide_incoming' => 'hide incoming properties that link here', #title of properties
24 - 'swb_browse_no_outgoing' => 'This page has no properties.', #text: page has no properties
25 - 'swb_browse_no_incoming' => 'No properties link to this page.', #text:page has no incoming properties
26 - 'swb_inverse_label_property' => 'Inverse property label', # this is the name of a special property
27 - 'swb_inverse_label_default' => '$1 of', #text : inverse label dafault,$1 is place marker, have not to be translated
28 - 'swb_browse_more' => '…', #text: browse more details
29 -);
\ No newline at end of file
 27+/** Message documentation (Message documentation)
 28+ * @author Benedikt Kämpgen
 29+ */
 30+$messages['en'] = array(
 31+ 'browsewiki' => 'Title of the SWB page',
 32+ 'swb_browse_semantic_web' => 'Title for browsing',
 33+ 'swb_browse_article' => 'Text above "go" window',
 34+ 'swb_browse_go' => 'Title of button "go"',
 35+ 'swb_browse_show_incoming' => 'Title of properties',
 36+ 'swb_browse_hide_incoming' => 'Title of properties',
 37+ 'swb_inverse_label_property' => 'Name of a special property',
 38+ 'swb_inverse_label_default' => 'Inverse label default, $1 is a place marker',
 39+ 'swb_browse_more' => 'Browse more details',
 40+);
 41+

Follow-up revisions

RevisionCommit summaryAuthorDate
r105169FU r105167: Fix language code of message documenation en->qqqraymond12:24, 5 December 2011
r105170FU r105167: Fixing parse error, define arrayraymond12:27, 5 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104375== SWB - 2011-11-27 ==...bkaempgen23:21, 27 November 2011

Status & tagging log