r105162 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r105161‎ | r105162 | r105163 >
Date:10:56, 5 December 2011
Author:hashar
Status:reverted (Comments)
Tags:
Comment:
Fix PageHistoryBeforeList hook

Following r100534 refactoring, it was using an incorrect variable.
Use the new accessor instead.
Modified paths:
  • /trunk/phase3/includes/actions/HistoryAction.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/actions/HistoryAction.php
——@@ -171,7 +171,7 @@
172172 '</fieldset></form>'
173173 );
174174
175 - wfRunHooks( 'PageHistoryBeforeList', array( &$this->article ) );
 175+ wfRunHooks( 'PageHistoryBeforeList', array( &$this->getArticle() ) );
176176
177177 // Create and output the list.
178178 $pager = new HistoryPager( $this, $year, $month, $tagFilter, $conds );

Follow-up revisions

RevisionCommit summaryAuthorDate
r105171Revert r105162 for now per CR.raymond12:47, 5 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100534* Changed action=history to use an Action subclass...ialex09:21, 23 October 2011

Comments

#Comment by Raymond (talk | contribs)   12:28, 5 December 2011

PHP Fatal error: Can't use method return value in write context in /www/w/includes/actions/HistoryAction.php on line 174

#Comment by Hashar (talk | contribs)   12:39, 5 December 2011

revert this. need to use $this->page instead and keep the &.

Status & tagging log