r104986 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104985‎ | r104986 | r104987 >
Date:18:16, 2 December 2011
Author:seanheavey
Status:deferred
Tags:
Comment:
updates for icons in option 2
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-hov.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-praise-off.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-praise-on.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-problem-off.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-problem-on.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-question-off.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-question-on.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-suggestion-off.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-suggestion-on.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-problem-off.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-praise-off.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-praise-on.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-suggestion-off.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-suggestion-on.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-problem-on.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-question-off.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-tag-question-on.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg-button-hov.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
@@ -607,13 +607,8 @@
608608 margin: 0 0 0 10px;
609609 line-height: 28px;
610610 height: 28px;
611 - padding: 0 8px;
612 - background: #e6e6e6;
613 - border: 1px solid #d6d6d6;
614 - -moz-border-radius: 8px;
615 - -webkit-border-radius: 8px;
616 - border-radius: 8px; /* future proofing */
617 - -khtml-border-radius: 8px; /* for old Konqueror browsers */
 611+ padding: 1px 9px;
 612+
618613 position: relative;
619614 }
620615
@@ -622,9 +617,15 @@
623618 }
624619
625620 .articleFeedbackv5-tags ul li:hover, .articleFeedbackv5-tags ul li.active {
 621+ padding: 0 8px;
626622 background: #fff;
627623 border-color: #ccc;
628624 color: #000;
 625+ border: 1px solid #d6d6d6;
 626+ -moz-border-radius: 8px;
 627+ -webkit-border-radius: 8px;
 628+ border-radius: 8px; /* future proofing */
 629+ -khtml-border-radius: 8px; /* for old Konqueror browsers */
629630 }
630631
631632 .articleFeedbackv5-tags ul li.active .tag-selector {
@@ -651,22 +652,22 @@
652653 }
653654
654655 .articleFeedbackv5-tags ul li .articleFeedbackv5-bucket2-suggestion-label {
655 - background: url(images/bg-tag-suggestion-off.png) no-repeat 0 center;
 656+ background: url(images/bg-tag-suggestion-on.png) no-repeat 0 center;
656657 }
657658
658659 .articleFeedbackv5-tags ul li .articleFeedbackv5-bucket2-question-label {
659 - background: url(images/bg-tag-question-off.png) no-repeat 0 center;
 660+ background: url(images/bg-tag-question-on.png) no-repeat 0 center;
660661 }
661662
662663 .articleFeedbackv5-tags ul li .articleFeedbackv5-bucket2-problem-label {
663 - background: url(images/bg-tag-problem-off.png) no-repeat 0 center;
 664+ background: url(images/bg-tag-problem-on.png) no-repeat 0 center;
664665 }
665666
666667 .articleFeedbackv5-tags ul li .articleFeedbackv5-bucket2-praise-label {
667 - background: url(images/bg-tag-praise-off.png) no-repeat 0 center;
 668+ background: url(images/bg-tag-praise-on.png) no-repeat 0 center;
668669 }
669670
670 -.articleFeedbackv5-tags ul li:hover .articleFeedbackv5-bucket2-suggestion-label,
 671+/*.articleFeedbackv5-tags ul li:hover .articleFeedbackv5-bucket2-suggestion-label,
671672 .articleFeedbackv5-tags ul li.active .articleFeedbackv5-bucket2-suggestion-label {
672673 background: url(images/bg-tag-suggestion-on.png) no-repeat 0 center;
673674 }
@@ -684,7 +685,7 @@
685686 .articleFeedbackv5-tags ul li:hover .articleFeedbackv5-bucket2-praise-label,
686687 .articleFeedbackv5-tags ul li.active .articleFeedbackv5-bucket2-praise-label {
687688 background: url(images/bg-tag-praise-on.png) no-repeat 0 center;
688 -}
 689+}*/
689690
690691 /*** Option 3 ***/
691692 .articleFeedbackv5-rating-new .articleFeedbackv5-rating-label {

Follow-up revisions

RevisionCommit summaryAuthorDate
r1049871.18wmf1: MFT r104986preilly18:24, 2 December 2011

Status & tagging log