r104971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104970‎ | r104971 | r104972 >
Date:14:29, 2 December 2011
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
(bug 32667) Change key name for Special:Contact in ContactPage extension. Was causing collisions.
Modified paths:
  • /trunk/extensions/ContactPage/ContactPage.i18n.php (modified) (history)
  • /trunk/extensions/ContactPage/SpecialContact.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ContactPage/SpecialContact.php
@@ -10,17 +10,11 @@
1111 * @license GNU General Public Licence 2.0 or later
1212 */
1313
14 -if( !defined( 'MEDIAWIKI' ) ) {
15 - echo( "not a valid entry point.\n" );
16 - die( 1 );
17 -}
18 -
1914 /**
2015 * Provides the contact form
2116 * @ingroup SpecialPage
2217 */
2318 class SpecialContact extends SpecialPage {
24 -
2519 /**
2620 * Constructor
2721 */
@@ -29,6 +23,13 @@
3024 }
3125
3226 /**
 27+ * @see SpecialPage::getDescription
 28+ */
 29+ function getDescription() {
 30+ return wfMsg( 'contactpage' );
 31+ }
 32+
 33+ /**
3334 * Main execution function
3435 *
3536 * @param $par Mixed: Parameters passed to the page
Index: trunk/extensions/ContactPage/ContactPage.i18n.php
@@ -15,7 +15,6 @@
1616 * @author Daniel Kinzler
1717 */
1818 $messages['en'] = array(
19 - 'contact' => 'Contact page',
2019 'contactpage' => 'Contact page',
2120 'contactpage-desc' => '[[Special:Contact|Contact form for visitors]]',
2221 'contactpage-title' => 'Contact',

Follow-up revisions

RevisionCommit summaryAuthorDate
r107976MFT r104971, r105275, r105902reedy00:44, 4 January 2012

Comments

#Comment by Liangent (talk | contribs)   15:12, 2 December 2011

Do we need to poke twn people to remove that message from their site?

#Comment by Siebrand (talk | contribs)   15:27, 2 December 2011

Aside from being part of twn people, the answer is no :).

#Comment by Liangent (talk | contribs)   15:30, 2 December 2011

Because you're in twn team so you already know this, or the system will do it automatically, or you think leaving it there is harmless?

btw. it's bug 32677, not bug 32667.

#Comment by Siebrand (talk | contribs)   16:47, 2 December 2011

It should all be in i18n. Let me know if it isn't.

#Comment by Liangent (talk | contribs)   17:14, 2 December 2011

Removing messages from an extension is not mentioned.

#Comment by Siebrand (talk | contribs)   08:38, 3 December 2011

IMO it was self explanatory, but I added documentation for that. Thanks for pointing it out.

Status & tagging log