r104697 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104696‎ | r104697 | r104698 >
Date:15:58, 30 November 2011
Author:j
Status:ok (Comments)
Tags:
Comment:
add concatenate no-op to ForeignAPIRepo.php
Follow up r104687
Modified paths:
  • /trunk/phase3/includes/filerepo/ForeignAPIRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/ForeignAPIRepo.php
——@@ -97,6 +97,10 @@
9898 return false;
9999 }
100100
 101+ function concatenate( $fileList, $targetPath, $flags = 0 ){
 102+ return false;
 103+ }
 104+
101105 function append( $srcPath, $toAppendPath, $flags = 0 ){
102106 return false;
103107 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104687Use database to track uploaded chunks and concatenate at the end....j14:56, 30 November 2011

Comments

#Comment by Platonides (talk | contribs)   22:42, 30 November 2011

Wouldn't have been preferable to add the dummy to FileRepo, and only override for those repos allowing concatenation?

#Comment by JanGerber (talk | contribs)   23:13, 30 November 2011

Could be, was doing it the same as append to make the code consistent. If adding a dummy to FileRepo is better it should be done for all relevant methods.

Status & tagging log