r104502 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104501‎ | r104502 | r104503 >
Date:22:52, 28 November 2011
Author:preilly
Status:deferred (Comments)
Tags:mobile 
Comment:
Undefined variable: logoutHtml
Modified paths:
  • /trunk/extensions/MobileFrontend/views/layout/_footmenu_default.html.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/views/layout/_footmenu_default.html.php
@@ -19,7 +19,7 @@
2020 $imagesURL = self::$enableImagesURL;
2121 }
2222
23 -$logoutLink = ( $logoutHtml ) ? ' | ' . $logoutHtml : '';
 23+$logoutLink = ( !empty( $logoutHtml ) ) ? ' | ' . $logoutHtml : '';
2424
2525 $feedbackLink = ( self::$code == 'en' && self::$isBetaGroupMember ) ? "| <a href=\"{$leaveFeedbackURL}\">{$leaveFeedback}</a>" : '';
2626

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104133add logout link to footerpreilly02:45, 24 November 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   01:18, 13 December 2011

It's a better practice to define it, but define it to empty.

Status & tagging log