r104445 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104444‎ | r104445 | r104446 >
Date:15:43, 28 November 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Oh noes, moar http:// -> https://
Modified paths:
  • /trunk/phase3/includes/api/ApiBase.php (modified) (history)
  • /trunk/phase3/includes/api/ApiBlock.php (modified) (history)
  • /trunk/phase3/includes/api/ApiDelete.php (modified) (history)
  • /trunk/phase3/includes/api/ApiEditPage.php (modified) (history)
  • /trunk/phase3/includes/api/ApiEmailUser.php (modified) (history)
  • /trunk/phase3/includes/api/ApiExpandTemplates.php (modified) (history)
  • /trunk/phase3/includes/api/ApiFeedWatchlist.php (modified) (history)
  • /trunk/phase3/includes/api/ApiFormatBase.php (modified) (history)
  • /trunk/phase3/includes/api/ApiFormatXml.php (modified) (history)
  • /trunk/phase3/includes/api/ApiImport.php (modified) (history)
  • /trunk/phase3/includes/api/ApiLogin.php (modified) (history)
  • /trunk/phase3/includes/api/ApiLogout.php (modified) (history)
  • /trunk/phase3/includes/api/ApiMain.php (modified) (history)
  • /trunk/phase3/includes/api/ApiMove.php (modified) (history)
  • /trunk/phase3/includes/api/ApiOpenSearch.php (modified) (history)
  • /trunk/phase3/includes/api/ApiParamInfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiParse.php (modified) (history)
  • /trunk/phase3/includes/api/ApiPatrol.php (modified) (history)
  • /trunk/phase3/includes/api/ApiProtect.php (modified) (history)
  • /trunk/phase3/includes/api/ApiPurge.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQuery.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllCategories.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllLinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllimages.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllmessages.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllpages.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryBacklinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryBlocks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryCategories.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryCategoryInfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryCategoryMembers.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryDeletedrevs.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryDuplicateFiles.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryExtLinksUsage.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryExternalLinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryImageInfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryImages.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryInfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryLangLinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryLinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryLogEvents.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryPageProps.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryProtectedTitles.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryRecentChanges.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryRevisions.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQuerySearch.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQuerySiteinfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryUserContributions.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryUserInfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryUsers.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryWatchlist.php (modified) (history)
  • /trunk/phase3/includes/api/ApiRollback.php (modified) (history)
  • /trunk/phase3/includes/api/ApiRsd.php (modified) (history)
  • /trunk/phase3/includes/api/ApiUnblock.php (modified) (history)
  • /trunk/phase3/includes/api/ApiUndelete.php (modified) (history)
  • /trunk/phase3/includes/api/ApiUpload.php (modified) (history)
  • /trunk/phase3/includes/api/ApiUserrights.php (modified) (history)
  • /trunk/phase3/includes/api/ApiWatch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRecentChanges.php
——@@ -634,7 +634,7 @@
635635 }
636636
637637 public function getHelpUrls() {
638 - return 'http://www.mediawiki.org/wiki/API:Recentchanges';
 638+ return 'https://www.mediawiki.org/wiki/API:Recentchanges';
639639 }
640640
641641 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryAllLinks.php
——@@ -223,7 +223,7 @@
224224 }
225225
226226 public function getHelpUrls() {
227 - return 'http://www.mediawiki.org/wiki/API:Alllinks';
 227+ return 'https://www.mediawiki.org/wiki/API:Alllinks';
228228 }
229229
230230 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryAllCategories.php
——@@ -199,7 +199,7 @@
200200 }
201201
202202 public function getHelpUrls() {
203 - return 'http://www.mediawiki.org/wiki/API:Allcategories';
 203+ return 'https://www.mediawiki.org/wiki/API:Allcategories';
204204 }
205205
206206 public function getVersion() {
Index: trunk/phase3/includes/api/ApiWatch.php
——@@ -120,7 +120,7 @@
121121 }
122122
123123 public function getHelpUrls() {
124 - return 'http://www.mediawiki.org/wiki/API:Watch';
 124+ return 'https://www.mediawiki.org/wiki/API:Watch';
125125 }
126126
127127 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQuerySiteinfo.php
——@@ -636,7 +636,7 @@
637637 }
638638
639639 public function getHelpUrls() {
640 - return 'http://www.mediawiki.org/wiki/API:Meta#siteinfo_.2F_si';
 640+ return 'https://www.mediawiki.org/wiki/API:Meta#siteinfo_.2F_si';
641641 }
642642
643643 public function getVersion() {
Index: trunk/phase3/includes/api/ApiMove.php
——@@ -256,7 +256,7 @@
257257 }
258258
259259 public function getHelpUrls() {
260 - return 'http://www.mediawiki.org/wiki/API:Move';
 260+ return 'https://www.mediawiki.org/wiki/API:Move';
261261 }
262262
263263 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryLinks.php
——@@ -44,7 +44,7 @@
4545 $this->description = 'link';
4646 $this->titlesParam = 'titles';
4747 $this->titlesParamDescription = 'Only list links to these titles. Useful for checking whether a certain page links to a certain title.';
48 - $this->helpUrl = 'http://www.mediawiki.org/wiki/API:Properties#links_.2F_pl';
 48+ $this->helpUrl = 'https://www.mediawiki.org/wiki/API:Properties#links_.2F_pl';
4949 break;
5050 case self::TEMPLATES:
5151 $this->table = 'templatelinks';
——@@ -52,7 +52,7 @@
5353 $this->description = 'template';
5454 $this->titlesParam = 'templates';
5555 $this->titlesParamDescription = 'Only list these templates. Useful for checking whether a certain page uses a certain template.';
56 - $this->helpUrl = 'http://www.mediawiki.org/wiki/API:Properties#templates_.2F_tl';
 56+ $this->helpUrl = 'https://www.mediawiki.org/wiki/API:Properties#templates_.2F_tl';
5757 break;
5858 default:
5959 ApiBase::dieDebug( __METHOD__, 'Unknown module name' );
Index: trunk/phase3/includes/api/ApiLogout.php
——@@ -69,7 +69,7 @@
7070 }
7171
7272 public function getHelpUrls() {
73 - return 'http://www.mediawiki.org/wiki/API:Logout';
 73+ return 'https://www.mediawiki.org/wiki/API:Logout';
7474 }
7575
7676 public function getVersion() {
Index: trunk/phase3/includes/api/ApiParse.php
——@@ -585,7 +585,7 @@
586586 }
587587
588588 public function getHelpUrls() {
589 - return 'http://www.mediawiki.org/wiki/API:Parsing_wikitext#parse';
 589+ return 'https://www.mediawiki.org/wiki/API:Parsing_wikitext#parse';
590590 }
591591
592592 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryExtLinksUsage.php
——@@ -249,7 +249,7 @@
250250 }
251251
252252 public function getHelpUrls() {
253 - return 'http://www.mediawiki.org/wiki/API:Exturlusage';
 253+ return 'https://www.mediawiki.org/wiki/API:Exturlusage';
254254 }
255255
256256 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryAllpages.php
——@@ -321,7 +321,7 @@
322322 }
323323
324324 public function getHelpUrls() {
325 - return 'http://www.mediawiki.org/wiki/API:Allpages';
 325+ return 'https://www.mediawiki.org/wiki/API:Allpages';
326326 }
327327
328328 public function getVersion() {
Index: trunk/phase3/includes/api/ApiProtect.php
——@@ -220,7 +220,7 @@
221221 }
222222
223223 public function getHelpUrls() {
224 - return 'http://www.mediawiki.org/wiki/API:Protect';
 224+ return 'https://www.mediawiki.org/wiki/API:Protect';
225225 }
226226
227227 public function getVersion() {
Index: trunk/phase3/includes/api/ApiPurge.php
——@@ -139,7 +139,7 @@
140140 }
141141
142142 public function getHelpUrls() {
143 - return 'http://www.mediawiki.org/wiki/API:Purge';
 143+ return 'https://www.mediawiki.org/wiki/API:Purge';
144144 }
145145
146146 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryPageProps.php
——@@ -144,7 +144,7 @@
145145 }
146146
147147 public function getHelpUrls() {
148 - return 'http://www.mediawiki.org/wiki/API:Properties#pageprops_.2F_pp';
 148+ return 'https://www.mediawiki.org/wiki/API:Properties#pageprops_.2F_pp';
149149 }
150150
151151 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryBacklinks.php
——@@ -59,19 +59,19 @@
6060 'code' => 'bl',
6161 'prefix' => 'pl',
6262 'linktbl' => 'pagelinks',
63 - 'helpurl' => 'http://www.mediawiki.org/wiki/API:Backlinks',
 63+ 'helpurl' => 'https://www.mediawiki.org/wiki/API:Backlinks',
6464 ),
6565 'embeddedin' => array(
6666 'code' => 'ei',
6767 'prefix' => 'tl',
6868 'linktbl' => 'templatelinks',
69 - 'helpurl' => 'http://www.mediawiki.org/wiki/API:Embeddedin',
 69+ 'helpurl' => 'https://www.mediawiki.org/wiki/API:Embeddedin',
7070 ),
7171 'imageusage' => array(
7272 'code' => 'iu',
7373 'prefix' => 'il',
7474 'linktbl' => 'imagelinks',
75 - 'helpurl' => 'http://www.mediawiki.org/wiki/API:Imageusage',
 75+ 'helpurl' => 'https://www.mediawiki.org/wiki/API:Imageusage',
7676 )
7777 );
7878
Index: trunk/phase3/includes/api/ApiRollback.php
——@@ -187,7 +187,7 @@
188188 }
189189
190190 public function getHelpUrls() {
191 - return 'http://www.mediawiki.org/wiki/API:Rollback';
 191+ return 'https://www.mediawiki.org/wiki/API:Rollback';
192192 }
193193
194194 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryDeletedrevs.php
——@@ -394,7 +394,7 @@
395395 }
396396
397397 public function getHelpUrls() {
398 - return 'http://www.mediawiki.org/wiki/API:Deletedrevs';
 398+ return 'https://www.mediawiki.org/wiki/API:Deletedrevs';
399399 }
400400
401401 public function getVersion() {
Index: trunk/phase3/includes/api/ApiExpandTemplates.php
——@@ -120,7 +120,7 @@
121121 }
122122
123123 public function getHelpUrls() {
124 - return 'http://www.mediawiki.org/wiki/API:Parsing_wikitext#expandtemplates';
 124+ return 'https://www.mediawiki.org/wiki/API:Parsing_wikitext#expandtemplates';
125125 }
126126
127127 public function getVersion() {
Index: trunk/phase3/includes/api/ApiUserrights.php
——@@ -135,7 +135,7 @@
136136 }
137137
138138 public function getHelpUrls() {
139 - return 'http://www.mediawiki.org/wiki/API:User_group_membership';
 139+ return 'https://www.mediawiki.org/wiki/API:User_group_membership';
140140 }
141141
142142 public function getVersion() {
Index: trunk/phase3/includes/api/ApiDelete.php
——@@ -274,7 +274,7 @@
275275 }
276276
277277 public function getHelpUrls() {
278 - return 'http://www.mediawiki.org/wiki/API:Delete';
 278+ return 'https://www.mediawiki.org/wiki/API:Delete';
279279 }
280280
281281 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryBlocks.php
——@@ -339,7 +339,7 @@
340340 }
341341
342342 public function getHelpUrls() {
343 - return 'http://www.mediawiki.org/wiki/API:Blocks';
 343+ return 'https://www.mediawiki.org/wiki/API:Blocks';
344344 }
345345
346346 public function getVersion() {
Index: trunk/phase3/includes/api/ApiImport.php
——@@ -160,7 +160,7 @@
161161 }
162162
163163 public function getHelpUrls() {
164 - return 'http://www.mediawiki.org/wiki/API:Import';
 164+ return 'https://www.mediawiki.org/wiki/API:Import';
165165 }
166166
167167 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryCategoryMembers.php
——@@ -397,7 +397,7 @@
398398 }
399399
400400 public function getHelpUrls() {
401 - return 'http://www.mediawiki.org/wiki/API:Categorymembers';
 401+ return 'https://www.mediawiki.org/wiki/API:Categorymembers';
402402 }
403403
404404 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryCategoryInfo.php
——@@ -115,7 +115,7 @@
116116 }
117117
118118 public function getHelpUrls() {
119 - return 'http://www.mediawiki.org/wiki/API:Properties#categoryinfo_.2F_ci';
 119+ return 'https://www.mediawiki.org/wiki/API:Properties#categoryinfo_.2F_ci';
120120 }
121121
122122 public function getVersion() {
Index: trunk/phase3/includes/api/ApiEditPage.php
——@@ -503,7 +503,7 @@
504504 }
505505
506506 public function getHelpUrls() {
507 - return 'http://www.mediawiki.org/wiki/API:Edit';
 507+ return 'https://www.mediawiki.org/wiki/API:Edit';
508508 }
509509
510510 public function getVersion() {
Index: trunk/phase3/includes/api/ApiFormatBase.php
——@@ -164,7 +164,7 @@
165165 <small>
166166 You are looking at the HTML representation of the <?php echo( $this->mFormat ); ?> format.<br />
167167 HTML is good for debugging, but probably is not suitable for your application.<br />
168 -See <a href='http://www.mediawiki.org/wiki/API'>complete documentation</a>, or
 168+See <a href='https://www.mediawiki.org/wiki/API'>complete documentation</a>, or
169169 <a href='<?php echo( $script ); ?>'>API help</a> for more information.
170170 </small>
171171 <?php
——@@ -290,7 +290,7 @@
291291 }
292292
293293 public function getHelpUrls() {
294 - return 'http://www.mediawiki.org/wiki/API:Data_formats';
 294+ return 'https://www.mediawiki.org/wiki/API:Data_formats';
295295 }
296296
297297 public function getDescription() {
Index: trunk/phase3/includes/api/ApiQueryAllimages.php
——@@ -256,7 +256,7 @@
257257 }
258258
259259 public function getHelpUrls() {
260 - return 'http://www.mediawiki.org/wiki/API:Allimages';
 260+ return 'https://www.mediawiki.org/wiki/API:Allimages';
261261 }
262262
263263 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryAllmessages.php
——@@ -241,7 +241,7 @@
242242 'prop' => 'Which properties to get',
243243 'enableparser' => array( 'Set to enable parser, will preprocess the wikitext of message',
244244 'Will substitute magic words, handle templates etc.' ),
245 - 'nocontent' => 'If set, do not include the content of the messages in the output.',
 245+ 'nocontent' => 'If set, do not include the content of the messages in the output.',
246246 'includelocal' => array( "Also include local messages, i.e. messages that don't exist in the software but do exist as a MediaWiki: page.",
247247 "This lists all MediaWiki: pages, so it will also list those that aren't 'really' messages such as Common.js",
248248 ),
——@@ -268,7 +268,7 @@
269269 }
270270
271271 public function getHelpUrls() {
272 - return 'http://www.mediawiki.org/wiki/API:Meta#allmessages_.2F_am';
 272+ return 'https://www.mediawiki.org/wiki/API:Meta#allmessages_.2F_am';
273273 }
274274
275275 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQuerySearch.php
——@@ -300,7 +300,7 @@
301301 }
302302
303303 public function getHelpUrls() {
304 - return 'http://www.mediawiki.org/wiki/API:Search';
 304+ return 'https://www.mediawiki.org/wiki/API:Search';
305305 }
306306
307307 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryLogEvents.php
——@@ -446,7 +446,7 @@
447447 }
448448
449449 public function getHelpUrls() {
450 - return 'http://www.mediawiki.org/wiki/API:Logevents';
 450+ return 'https://www.mediawiki.org/wiki/API:Logevents';
451451 }
452452
453453 public function getVersion() {
Index: trunk/phase3/includes/api/ApiUnblock.php
——@@ -144,7 +144,7 @@
145145 }
146146
147147 public function getHelpUrls() {
148 - return 'http://www.mediawiki.org/wiki/API:Block';
 148+ return 'https://www.mediawiki.org/wiki/API:Block';
149149 }
150150
151151 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryProtectedTitles.php
——@@ -225,7 +225,7 @@
226226 }
227227
228228 public function getHelpUrls() {
229 - return 'http://www.mediawiki.org/wiki/API:Protectedtitles';
 229+ return 'https://www.mediawiki.org/wiki/API:Protectedtitles';
230230 }
231231
232232 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQuery.php
——@@ -701,9 +701,9 @@
702702
703703 public function getHelpUrls() {
704704 return array(
705 - 'http://www.mediawiki.org/wiki/API:Meta',
706 - 'http://www.mediawiki.org/wiki/API:Properties',
707 - 'http://www.mediawiki.org/wiki/API:Lists',
 705+ 'https://www.mediawiki.org/wiki/API:Meta',
 706+ 'https://www.mediawiki.org/wiki/API:Properties',
 707+ 'https://www.mediawiki.org/wiki/API:Lists',
708708 );
709709 }
710710
Index: trunk/phase3/includes/api/ApiLogin.php
——@@ -214,7 +214,7 @@
215215 }
216216
217217 public function getHelpUrls() {
218 - return 'http://www.mediawiki.org/wiki/API:Login';
 218+ return 'https://www.mediawiki.org/wiki/API:Login';
219219 }
220220
221221 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryLangLinks.php
——@@ -177,7 +177,7 @@
178178 }
179179
180180 public function getHelpUrls() {
181 - return 'http://www.mediawiki.org/wiki/API:Properties#langlinks_.2F_ll';
 181+ return 'https://www.mediawiki.org/wiki/API:Properties#langlinks_.2F_ll';
182182 }
183183
184184 public function getVersion() {
Index: trunk/phase3/includes/api/ApiFormatXml.php
——@@ -31,7 +31,7 @@
3232 class ApiFormatXml extends ApiFormatBase {
3333
3434 private $mRootElemName = 'api';
35 - public static $namespace = 'http://www.mediawiki.org/xml/api/';
 35+ public static $namespace = 'https://www.mediawiki.org/xml/api/';
3636 private $mDoubleQuote = false;
3737 private $mIncludeNamespace = false;
3838 private $mXslt = null;
Index: trunk/phase3/includes/api/ApiQueryUserInfo.php
——@@ -243,7 +243,7 @@
244244 }
245245
246246 public function getHelpUrls() {
247 - return 'http://www.mediawiki.org/wiki/API:Meta#userinfo_.2F_ui';
 247+ return 'https://www.mediawiki.org/wiki/API:Meta#userinfo_.2F_ui';
248248 }
249249
250250 public function getVersion() {
Index: trunk/phase3/includes/api/ApiMain.php
——@@ -790,7 +790,7 @@
791791 'wait until the replication lag is less than the specified value.',
792792 'In case of a replag error, a HTTP 503 error is returned, with the message like',
793793 '"Waiting for $host: $lag seconds lagged\n".',
794 - 'See http://www.mediawiki.org/wiki/Manual:Maxlag_parameter for more information',
 794+ 'See https://www.mediawiki.org/wiki/Manual:Maxlag_parameter for more information',
795795 ),
796796 'smaxage' => 'Set the s-maxage header to this many seconds. Errors are never cached',
797797 'maxage' => 'Set the max-age header to this many seconds. Errors are never cached',
——@@ -813,7 +813,7 @@
814814 '** This is an auto-generated MediaWiki API documentation page **',
815815 '** **',
816816 '** Documentation and Examples: **',
817 - '** http://www.mediawiki.org/wiki/API **',
 817+ '** https://www.mediawiki.org/wiki/API **',
818818 '** **',
819819 '**********************************************************************************************************',
820820 '',
——@@ -828,7 +828,7 @@
829829 ' In the case of an invalid action being passed, these will have a value',
830830 ' of "unknown_action"',
831831 '',
832 - ' For more information see http://www.mediawiki.org/wiki/API:Errors_and_warnings',
 832+ ' For more information see https://www.mediawiki.org/wiki/API:Errors_and_warnings',
833833 '',
834834 'Documentation: https://www.mediawiki.org/wiki/API:Main_page',
835835 'FAQ https://www.mediawiki.org/wiki/API:FAQ',
——@@ -870,7 +870,7 @@
871871 ' Yuri Astrakhan <Firstname><Lastname>@gmail.com (creator, lead developer Sep 2006-Sep 2007)',
872872 '',
873873 'Please send your comments, suggestions and questions to mediawiki-api@lists.wikimedia.org',
874 - 'or file a bug report at http://bugzilla.wikimedia.org/'
 874+ 'or file a bug report at https://bugzilla.wikimedia.org/'
875875 );
876876 }
877877
——@@ -997,7 +997,7 @@
998998 */
999999 public function getVersion() {
10001000 $vers = array();
1001 - $vers[] = 'MediaWiki: ' . SpecialVersion::getVersion() . "\n http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/";
 1001+ $vers[] = 'MediaWiki: ' . SpecialVersion::getVersion() . "\n https://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/";
10021002 $vers[] = __CLASS__ . ': $Id$';
10031003 $vers[] = ApiBase::getBaseVersion();
10041004 $vers[] = ApiFormatBase::getBaseVersion();
Index: trunk/phase3/includes/api/ApiQueryImageInfo.php
——@@ -570,7 +570,7 @@
571571 }
572572
573573 public function getHelpUrls() {
574 - return 'http://www.mediawiki.org/wiki/API:Properties#imageinfo_.2F_ii';
 574+ return 'https://www.mediawiki.org/wiki/API:Properties#imageinfo_.2F_ii';
575575 }
576576
577577 public function getVersion() {
Index: trunk/phase3/includes/api/ApiEmailUser.php
——@@ -138,7 +138,7 @@
139139 }
140140
141141 public function getHelpUrls() {
142 - return 'http://www.mediawiki.org/wiki/API:E-mail';
 142+ return 'https://www.mediawiki.org/wiki/API:E-mail';
143143 }
144144
145145 public function getVersion() {
Index: trunk/phase3/includes/api/ApiOpenSearch.php
——@@ -121,7 +121,7 @@
122122 }
123123
124124 public function getHelpUrls() {
125 - return 'http://www.mediawiki.org/wiki/API:Opensearch';
 125+ return 'https://www.mediawiki.org/wiki/API:Opensearch';
126126 }
127127
128128 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryWatchlist.php
——@@ -129,7 +129,7 @@
130130
131131 $db = $this->getDB();
132132
133 - $this->addTimestampWhereRange( 'rc_timestamp', $params['dir'],
 133+ $this->addTimestampWhereRange( 'rc_timestamp', $params['dir'],
134134 $params['start'], $params['end'] );
135135 $this->addWhereFld( 'wl_namespace', $params['namespace'] );
136136
——@@ -445,7 +445,7 @@
446446 }
447447
448448 public function getHelpUrls() {
449 - return 'http://www.mediawiki.org/wiki/API:Watchlist';
 449+ return 'https://www.mediawiki.org/wiki/API:Watchlist';
450450 }
451451
452452 public function getVersion() {
Index: trunk/phase3/includes/api/ApiRsd.php
——@@ -43,7 +43,7 @@
4444
4545 $service = array( 'apis' => $this->formatRsdApiList() );
4646 ApiResult::setContent( $service, 'MediaWiki', 'engineName' );
47 - ApiResult::setContent( $service, 'http://www.mediawiki.org/', 'engineLink' );
 47+ ApiResult::setContent( $service, 'https://www.mediawiki.org/', 'engineLink' );
4848 ApiResult::setContent( $service, Title::newMainPage()->getCanonicalUrl(), 'homePageLink' );
4949
5050 $result->setIndexedTagName( $service['apis'], 'api' );
——@@ -97,7 +97,7 @@
9898 'apiLink' => wfExpandUrl( wfScript( 'api' ), PROTO_CURRENT ),
9999
100100 // Docs link is optional, but recommended.
101 - 'docs' => 'http://www.mediawiki.org/wiki/API',
 101+ 'docs' => 'https://www.mediawiki.org/wiki/API',
102102
103103 // Some APIs may need a blog ID, but it may be left blank.
104104 'blogID' => '',
Index: trunk/phase3/includes/api/ApiBlock.php
——@@ -211,7 +211,7 @@
212212 }
213213
214214 public function getHelpUrls() {
215 - return 'http://www.mediawiki.org/wiki/API:Block';
 215+ return 'https://www.mediawiki.org/wiki/API:Block';
216216 }
217217
218218 public function getVersion() {
Index: trunk/phase3/includes/api/ApiPatrol.php
——@@ -105,7 +105,7 @@
106106 }
107107
108108 public function getHelpUrls() {
109 - return 'http://www.mediawiki.org/wiki/API:Patrol';
 109+ return 'https://www.mediawiki.org/wiki/API:Patrol';
110110 }
111111
112112 public function getVersion() {
Index: trunk/phase3/includes/api/ApiUndelete.php
——@@ -154,7 +154,7 @@
155155 }
156156
157157 public function getHelpUrls() {
158 - return 'http://www.mediawiki.org/wiki/API:Undelete';
 158+ return 'https://www.mediawiki.org/wiki/API:Undelete';
159159 }
160160
161161 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryRevisions.php
——@@ -665,7 +665,7 @@
666666 }
667667
668668 public function getHelpUrls() {
669 - return 'http://www.mediawiki.org/wiki/API:Properties#revisions_.2F_rv';
 669+ return 'https://www.mediawiki.org/wiki/API:Properties#revisions_.2F_rv';
670670 }
671671
672672 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryExternalLinks.php
——@@ -151,7 +151,7 @@
152152 }
153153
154154 public function getHelpUrls() {
155 - return 'http://www.mediawiki.org/wiki/API:Properties#extlinks_.2F_el';
 155+ return 'https://www.mediawiki.org/wiki/API:Properties#extlinks_.2F_el';
156156 }
157157
158158 public function getVersion() {
Index: trunk/phase3/includes/api/ApiBase.php
——@@ -463,7 +463,7 @@
464464 // This is necessary to make stuff like ApiMain::getVersion()
465465 // returning the version string for ApiBase work
466466 if ( $path ) {
467 - return "{$matches[0]}\n http://svn.wikimedia.org/" .
 467+ return "{$matches[0]}\n https://svn.wikimedia.org/" .
468468 "viewvc/mediawiki/trunk/" . dirname( $path ) .
469469 "/{$matches[2]}";
470470 }
Index: trunk/phase3/includes/api/ApiQueryCategories.php
——@@ -259,7 +259,7 @@
260260 }
261261
262262 public function getHelpUrls() {
263 - return 'http://www.mediawiki.org/wiki/API:Properties#categories_.2F_cl';
 263+ return 'https://www.mediawiki.org/wiki/API:Properties#categories_.2F_cl';
264264 }
265265
266266 public function getVersion() {
Index: trunk/phase3/includes/api/ApiParamInfo.php
——@@ -280,7 +280,7 @@
281281 }
282282
283283 public function getHelpUrls() {
284 - return 'http://www.mediawiki.org/wiki/API:Parameter_information';
 284+ return 'https://www.mediawiki.org/wiki/API:Parameter_information';
285285 }
286286
287287 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
——@@ -229,7 +229,7 @@
230230 ApiBase::dieDebug( __METHOD__,
231231 'MediaWiki configuration error: the database contains more user groups than known to User::getAllGroups() function' );
232232 }
233 -
 233+
234234 $lastUserObj = User::newFromName( $lastUser );
235235
236236 // Add user's group info
——@@ -366,7 +366,7 @@
367367 }
368368
369369 public function getHelpUrls() {
370 - return 'http://www.mediawiki.org/wiki/API:Allusers';
 370+ return 'https://www.mediawiki.org/wiki/API:Allusers';
371371 }
372372
373373 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryInfo.php
——@@ -724,7 +724,7 @@
725725 }
726726
727727 public function getHelpUrls() {
728 - return 'http://www.mediawiki.org/wiki/API:Properties#info_.2F_in';
 728+ return 'https://www.mediawiki.org/wiki/API:Properties#info_.2F_in';
729729 }
730730
731731 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryDuplicateFiles.php
——@@ -173,7 +173,7 @@
174174 }
175175
176176 public function getHelpUrls() {
177 - return 'http://www.mediawiki.org/wiki/API:Properties#duplicatefiles_.2F_df';
 177+ return 'https://www.mediawiki.org/wiki/API:Properties#duplicatefiles_.2F_df';
178178 }
179179
180180 public function getVersion() {
Index: trunk/phase3/includes/api/ApiUpload.php
——@@ -609,7 +609,7 @@
610610 }
611611
612612 public function getHelpUrls() {
613 - return 'http://www.mediawiki.org/wiki/API:Upload';
 613+ return 'https://www.mediawiki.org/wiki/API:Upload';
614614 }
615615
616616 public function getVersion() {
Index: trunk/phase3/includes/api/ApiFeedWatchlist.php
——@@ -230,7 +230,7 @@
231231 }
232232
233233 public function getHelpUrls() {
234 - return 'http://www.mediawiki.org/wiki/API:Watchlist_feed';
 234+ return 'https://www.mediawiki.org/wiki/API:Watchlist_feed';
235235 }
236236
237237 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryUserContributions.php
——@@ -468,7 +468,7 @@
469469 }
470470
471471 public function getHelpUrls() {
472 - return 'http://www.mediawiki.org/wiki/API:Usercontribs';
 472+ return 'https://www.mediawiki.org/wiki/API:Usercontribs';
473473 }
474474
475475 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryUsers.php
——@@ -322,7 +322,7 @@
323323 }
324324
325325 public function getHelpUrls() {
326 - return 'http://www.mediawiki.org/wiki/API:Users';
 326+ return 'https://www.mediawiki.org/wiki/API:Users';
327327 }
328328
329329 public function getVersion() {
Index: trunk/phase3/includes/api/ApiQueryImages.php
——@@ -193,7 +193,7 @@
194194 }
195195
196196 public function getHelpUrls() {
197 - return 'http://www.mediawiki.org/wiki/API:Properties#images_.2F_im';
 197+ return 'https://www.mediawiki.org/wiki/API:Properties#images_.2F_im';
198198 }
199199
200200 public function getVersion() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r1044481.18wmf1 MFT r104445reedy15:49, 28 November 2011
r104449REL1_18 MFT r104445reedy15:52, 28 November 2011
r104475Followup r104445, swap the xmlnamespace url back to http://reedy20:04, 28 November 2011

Comments

#Comment by Platonides (talk | contribs)   15:54, 28 November 2011

You shouldn't be changing the xml namespace r1=104444&r2=104445

#Comment by Reedy (talk | contribs)   16:04, 28 November 2011

Does it really make any difference if it's HTTPS or not? I can revert it back if needed

#Comment by Brion VIBBER (talk | contribs)   20:01, 28 November 2011

Yes, changing the URL in any way will cause anything looking for the old URL to fail to match it.

#Comment by Platonides (talk | contribs)   16:03, 28 November 2011

The enginelink also seemed suspicious, but is apparently not used for identification r1=104444&r2=104445. So other than the xml namespace, it's ok.

Status & tagging log