r104436 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104435‎ | r104436 | r104437 >
Date:15:19, 28 November 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
use meaningful test in a parser test

Readin the text case, I though 'pre' was some kind of magic keyword to render
a preformatted text. It happens it is just a text. Replacing it with something
that will not confuse me or others.

follow up r103933
Modified paths:
  • /trunk/phase3/tests/parser/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/parser/parserTests.txt
——@@ -1484,7 +1484,7 @@
14851485 <table>
14861486 <tr>
14871487 <td>
1488 - pre
 1488+ Text that should be rendered preformatted
14891489 </td>
14901490 </tr>
14911491 </table>
——@@ -1492,7 +1492,7 @@
14931493 <table>
14941494 <tr>
14951495 <td>
1496 -<pre>pre
 1496+<pre>Text that should be rendered preformatted
14971497 </pre>
14981498 </td>
14991499 </tr>

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103933Add test case described by Vitaliy Filippov in bug 6200.gwicke18:14, 22 November 2011

Comments

#Comment by Platonides (talk | contribs)   15:22, 28 November 2011

Indeed. This kind of things make you spend a lot of time, and finally make you look like a fool. The parser tests should be blatantly clear. In this case, the ignored space before html tags makes things more confusing.

#Comment by Nikerabbit (talk | contribs)   06:52, 30 November 2011

Isn't the primary point of this text that the newline gets preserved?

Status & tagging log