r104434 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104433‎ | r104434 | r104435 >
Date:15:17, 28 November 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Https for all!

(omg, this hadn't been reported)
Modified paths:
  • /trunk/phase3/includes/api/ApiHelp.php (modified) (history)
  • /trunk/phase3/includes/api/ApiMain.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiMain.php
——@@ -830,11 +830,11 @@
831831 '',
832832 ' For more information see http://www.mediawiki.org/wiki/API:Errors_and_warnings',
833833 '',
834 - 'Documentation: http://www.mediawiki.org/wiki/API:Main_page',
835 - 'FAQ http://www.mediawiki.org/wiki/API:FAQ',
836 - 'Mailing list: http://lists.wikimedia.org/mailman/listinfo/mediawiki-api',
837 - 'Api Announcements: http://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce',
838 - 'Bugs & Requests: http://bugzilla.wikimedia.org/buglist.cgi?component=API&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&order=bugs.delta_ts',
 834+ 'Documentation: https://www.mediawiki.org/wiki/API:Main_page',
 835+ 'FAQ https://www.mediawiki.org/wiki/API:FAQ',
 836+ 'Mailing list: https://lists.wikimedia.org/mailman/listinfo/mediawiki-api',
 837+ 'Api Announcements: https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce',
 838+ 'Bugs & Requests: https://bugzilla.wikimedia.org/buglist.cgi?component=API&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&order=bugs.delta_ts',
839839 '',
840840 '',
841841 '',
Index: trunk/phase3/includes/api/ApiHelp.php
——@@ -151,9 +151,9 @@
152152
153153 public function getHelpUrls() {
154154 return array(
155 - 'http://www.mediawiki.org/wiki/API:Main_page',
156 - 'http://www.mediawiki.org/wiki/API:FAQ',
157 - 'http://www.mediawiki.org/wiki/API:Quick_start_guide',
 155+ 'https://www.mediawiki.org/wiki/API:Main_page',
 156+ 'https://www.mediawiki.org/wiki/API:FAQ',
 157+ 'https://www.mediawiki.org/wiki/API:Quick_start_guide',
158158 );
159159 }
160160

Follow-up revisions

RevisionCommit summaryAuthorDate
r104439REL1_18, 1.18wmf1 MFT r104434reedy15:22, 28 November 2011

Comments

#Comment by Hashar (talk | contribs)   15:52, 28 November 2011

Don't we want relative URLs ? Some people might be denied HTTPS URLs (i.e. when behind an enterprise proxy).

#Comment by Platonides (talk | contribs)   15:56, 28 November 2011

This is documentation. I don't think many people would understand a protocol-relative link in text as an url. The best I guess is that they could be taking it as a samba share.

Status & tagging log