r104403 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104402‎ | r104403 | r104404 >
Date:06:45, 28 November 2011
Author:dale
Status:ok
Tags:
Comment:
fixed i18n for named mime types
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/EmbedPlayer.i18n.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.MediaSource.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.MediaSource.js
@@ -309,16 +309,16 @@
310310 return gM( 'mwe-embedplayer-video-audio' );
311311 break;
312312 case 'audio/mpeg' :
313 - return 'MPEG audio'; // FIXME: i18n
 313+ return gM('mwe-embedplayer-audio-mpeg');
314314 break;
315315 case 'video/3gp' :
316 - return '3gp video'; // FIXME: i18n
 316+ return gM('mwe-embedplayer-video-3gp');
317317 break;
318318 case 'video/mpeg' :
319 - return 'MPEG video'; // FIXME: i18n
 319+ return gM('mwe-embedplayer-video-mpeg');
320320 break;
321321 case 'video/x-msvideo' :
322 - return 'AVI video'; // FIXME: i18n
 322+ return gM('mwe-embedplayer-video-msvideo' );
323323 break;
324324 }
325325
Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/EmbedPlayer.i18n.php
@@ -78,7 +78,11 @@
7979 'mwe-embedplayer-video-webm' => 'WebM video',
8080 'mwe-embedplayer-video-flv' => 'Flash video',
8181 'mwe-embedplayer-video-ogg' => 'Ogg video',
82 - 'mwe-embedplayer-video-audio' => 'Ogg audio',
 82+ 'mwe-embedplayer-video-audio' => 'Ogg audio',
 83+ 'mwe-embedplayer-audio-mpeg' => 'MPEG audio',
 84+ 'mwe-embedplayer-video-3gp' => '3gp video',
 85+ 'mwe-embedplayer-video-mpeg' => 'MPEG video',
 86+ 'mwe-embedplayer-video-msvideo' => 'AVI video',
8387 'mwe-embedplayer-missing-source' => 'No source video was found',
8488 );
8589

Follow-up revisions

RevisionCommit summaryAuthorDate
r104661Tweak message from r104403: 3gp -> 3GP per https://en.wikipedia.org/wiki/3GP_...raymond09:25, 30 November 2011

Status & tagging log