r104392 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104391‎ | r104392 | r104393 >
Date:05:13, 28 November 2011
Author:santhosh
Status:resolved (Comments)
Tags:
Comment:
Correct the pointer behavior on the menu items.
Modified paths:
  • /trunk/extensions/WebFonts/resources/ext.webfonts.css (modified) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/resources/ext.webfonts.css
——@@ -32,7 +32,6 @@
3333 div.webfontMenu {
3434 direction: ltr;
3535 float: left;
36 - cursor: pointer;
3736 }
3837 div.webfontMenuFocus {
3938 background-position: -22px 60%;
——@@ -108,7 +107,6 @@
109108 padding: 0.5em;
110109 white-space: nowrap;
111110 color: #0645ad;
112 - cursor: pointer;
113111 font-size: 0.8em;
114112 }
115113 /* IGNORED BY IE6 */
——@@ -125,3 +123,7 @@
126124 padding-left: 5px;
127125 padding-right: 5px;
128126 }
 127+
 128+div.webfontMenu label:hover, input:hover {
 129+ cursor: pointer;
 130+}

Follow-up revisions

RevisionCommit summaryAuthorDate
r106753Correct the css definition. Follow up r104392santhosh04:02, 20 December 2011

Comments

#Comment by Nikerabbit (talk | contribs)   09:08, 29 November 2011

The same fix should be done to Narayam and Kieli too.

#Comment by Bawolff (talk | contribs)   22:19, 19 December 2011

Did you mean to do: 

div.webfontMenu label:hover, div.webfontMenu input:hover {
      cursor: pointer;
}

Right now this triggers a hand ("pointer") cursor on any input box (including things like the Associate follow-up revision box on this very page)

Marking fixme because that looks unintentional, but I'm not 100% sure if this actually was unintentional, so if not, please ignore me.

Status & tagging log