r104343 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104342‎ | r104343 | r104344 >
Date:16:28, 27 November 2011
Author:platonides
Status:ok (Comments)
Tags:core 
Comment:
Bug 32673: Keep the username in the input field if not existing
We could also add on LogEventsList.php line 870
$this->performer = $name;
but that method is also used to build the query, which we don't want to affect.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialLog.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialLog.php
——@@ -144,7 +144,7 @@
145145 }
146146
147147 # Show form options
148 - $loglist->showOptions( $pager->getType(), $pager->getPerformer(), $pager->getPage(), $pager->getPattern(),
 148+ $loglist->showOptions( $pager->getType(), $opts->getValue( 'user' ), $pager->getPage(), $pager->getPattern(),
149149 $pager->getYear(), $pager->getMonth(), $pager->getFilterParams(), $opts->getValue( 'tagfilter' ) );
150150
151151 # Insert list

Comments

#Comment by Duplicatebug (talk | contribs)   16:55, 27 November 2011

But now the value is not normalized. Invalid usernames are kept, but invalid titles are removed (valid titles are normalized).

#Comment by Platonides (talk | contribs)   23:49, 27 November 2011

Can you provide an example?

If the provided user is normalised, we would be providing the unnormalized one, but if it was able to normalize it, it should be able to do that a second time, too.

#Comment by Duplicatebug (talk | contribs)   18:38, 30 November 2011

You can use a lower case username to test the normalization. A invalid username is with <, > or [, ]. Title aswell.

It looks nicer with a normalized username and other special pages also does that.

#Comment by Hashar (talk | contribs)   17:03, 17 January 2012

Platonides, can you have a look at this one again?

Status & tagging log