r104316 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104315‎ | r104316 | r104317 >
Date:21:57, 26 November 2011
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
Revert r104309, does not work.
Modified paths:
  • /trunk/extensions/VipsScaler/modules/ext.vipsScaler/ext.vipsScaler.js (modified) (history)

Diff [purge]

Index: trunk/extensions/VipsScaler/modules/ext.vipsScaler/ext.vipsScaler.js
@@ -66,7 +66,7 @@
6767 mask.width( width );
6868 caption.html( e.children("img:eq(0)").attr("alt") );
6969 } else {
70 - mask.width( -3 ); // Remove the border with width 3px
 70+ mask.width( 0 );
7171 caption.html( e.children("img:eq(1)").attr("alt") );
7272 }
7373 });

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104309Remove the border when using the click handlerbtongminh21:29, 26 November 2011

Comments

#Comment by Hashar (talk | contribs)   09:58, 28 November 2011

The .uc-mask element, does not have a width. The bar is rendered using a border width instead.

You can add a checkbox to enable/disable it by just changing the border width :)

Status & tagging log