r104285 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r104284‎ | r104285 | r104286 >
Date:17:43, 26 November 2011
Author:dantman
Status:reverted
Tags:
Comment:
Followup r104274; Add '$key' to the $data array as well.
Modified paths:
  • /trunk/phase3/includes/PathRouter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/PathRouter.php
——@@ -219,6 +219,9 @@
220220 $data['$'.$n] = $matchValue;
221221 }
222222 }
 223+ if ( isset( $pattern->key ) ) {
 224+ $data['$key'] = $pattern->key;
 225+ }
223226
224227 foreach ( $pattern->params as $paramName => $paramData ) {
225228 $value = null;

Follow-up revisions

RevisionCommit summaryAuthorDate
r104474Revert r104274, r104284, r104285 -- breaks special pages on non-englishbrion19:55, 28 November 2011
r104676Recommit PathRouter code from r104274, r104284, r104285 without the WebReques...dantman13:37, 30 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104274Implement path routing code....dantman16:29, 26 November 2011

Status & tagging log